Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: webrtc/video_frame.h

Issue 2383093002: Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (Closed)
Patch Set: objc: Add missing include of video_frame_buffer.h. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_VIDEO_FRAME_H_ 11 #ifndef WEBRTC_VIDEO_FRAME_H_
12 #define WEBRTC_VIDEO_FRAME_H_ 12 #define WEBRTC_VIDEO_FRAME_H_
13 13
14 #include "webrtc/base/scoped_ref_ptr.h" 14 #include "webrtc/base/scoped_ref_ptr.h"
15 #include "webrtc/base/timeutils.h" 15 #include "webrtc/base/timeutils.h"
16 #include "webrtc/common_types.h" 16 #include "webrtc/common_types.h"
17 #include "webrtc/common_video/include/video_frame_buffer.h" 17 #include "webrtc/common_video/include/video_frame_buffer.h"
18 #include "webrtc/common_video/rotation.h" 18 #include "webrtc/common_video/rotation.h"
19 #include "webrtc/typedefs.h" 19 #include "webrtc/typedefs.h"
20 20
21 namespace webrtc { 21 namespace webrtc {
22 22
23 // TODO(nisse): This class duplicates cricket::VideoFrame. There's
24 // ongoing work to merge the classes. See
25 // https://bugs.chromium.org/p/webrtc/issues/detail?id=5682.
26 class VideoFrame { 23 class VideoFrame {
27 public: 24 public:
28 // TODO(nisse): Deprecated. Using the default constructor violates the 25 // TODO(nisse): Deprecated. Using the default constructor violates the
29 // reasonable assumption that video_frame_buffer() returns a valid buffer. 26 // reasonable assumption that video_frame_buffer() returns a valid buffer.
30 VideoFrame(); 27 VideoFrame();
31 28
32 // TODO(nisse): This constructor is consistent with 29 // TODO(nisse): This constructor is consistent with
33 // cricket::WebRtcVideoFrame. After the class 30 // cricket::WebRtcVideoFrame. After the class
34 // cricket::WebRtcVideoFrame and its baseclass cricket::VideoFrame 31 // cricket::WebRtcVideoFrame and its baseclass cricket::VideoFrame
35 // are deleted, we should consider whether or not we want to stick 32 // are deleted, we should consider whether or not we want to stick
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 int qp_ = -1; // Quantizer value. 180 int qp_ = -1; // Quantizer value.
184 181
185 // When an application indicates non-zero values here, it is taken as an 182 // When an application indicates non-zero values here, it is taken as an
186 // indication that all future frames will be constrained with those limits 183 // indication that all future frames will be constrained with those limits
187 // until the application indicates a change again. 184 // until the application indicates a change again.
188 PlayoutDelay playout_delay_ = {-1, -1}; 185 PlayoutDelay playout_delay_ = {-1, -1};
189 }; 186 };
190 187
191 } // namespace webrtc 188 } // namespace webrtc
192 #endif // WEBRTC_VIDEO_FRAME_H_ 189 #endif // WEBRTC_VIDEO_FRAME_H_
OLDNEW
« no previous file with comments | « webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698