|
|
DescriptionFix receiving H264 video from iPhone on Kitkat devices.
Changing this constant has been empirically proven to solve the issue.
BUG=webrtc:6455
,b/31827852
Committed: https://crrev.com/65b42c251f6dec36e5db44414a10bfa1d092cde9
Cr-Commit-Position: refs/heads/master@{#14479}
Patch Set 1 #
Messages
Total messages: 29 (15 generated)
Description was changed from ========== Fix receiving H264 from iPhone video on Kitkat devices. BUG=b/31827852 ========== to ========== Fix receiving H264 from iPhone video on Kitkat devices. BUG=b/31827852 ==========
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
Description was changed from ========== Fix receiving H264 from iPhone video on Kitkat devices. BUG=b/31827852 ========== to ========== Fix receiving H264 from iPhone video on Kitkat devices. BUG=webrtc:6455,b/31827852 ==========
PTAL
Description was changed from ========== Fix receiving H264 from iPhone video on Kitkat devices. BUG=webrtc:6455,b/31827852 ========== to ========== Fix receiving H264 video from iPhone on Kitkat devices. BUG=webrtc:6455,b/31827852 ==========
Description was changed from ========== Fix receiving H264 video from iPhone on Kitkat devices. BUG=webrtc:6455,b/31827852 ========== to ========== Fix receiving H264 video from iPhone on Kitkat devices. Changing this constant has been empirically proven to solve the issue. BUG=webrtc:6455,b/31827852 ==========
lgtm - easy fix. We should look into if H264 VUI rewriting is broken.
magjed@webrtc.org changed reviewers: + glaznev@webrtc.org
I would like Alex to review this as well though. Increasing this variable won't increase the latency for other Android versions, right?
I don't think so. It affects to which point we drain the encoder if it falls behind though.
lgtm
The CQ bit was checked by glaznev@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_drmemory_light on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/buil...)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Fix receiving H264 video from iPhone on Kitkat devices. Changing this constant has been empirically proven to solve the issue. BUG=webrtc:6455,b/31827852 ========== to ========== Fix receiving H264 video from iPhone on Kitkat devices. Changing this constant has been empirically proven to solve the issue. BUG=webrtc:6455,b/31827852 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix receiving H264 video from iPhone on Kitkat devices. Changing this constant has been empirically proven to solve the issue. BUG=webrtc:6455,b/31827852 ========== to ========== Fix receiving H264 video from iPhone on Kitkat devices. Changing this constant has been empirically proven to solve the issue. BUG=webrtc:6455,b/31827852 Committed: https://crrev.com/65b42c251f6dec36e5db44414a10bfa1d092cde9 Cr-Commit-Position: refs/heads/master@{#14479} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/65b42c251f6dec36e5db44414a10bfa1d092cde9 Cr-Commit-Position: refs/heads/master@{#14479} |