Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2382733006: Fix receiving H264 video from iPhone on Kitkat devices. (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc, AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix receiving H264 video from iPhone on Kitkat devices. Changing this constant has been empirically proven to solve the issue. BUG=webrtc:6455 ,b/31827852 Committed: https://crrev.com/65b42c251f6dec36e5db44414a10bfa1d092cde9 Cr-Commit-Position: refs/heads/master@{#14479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/api/android/jni/androidmediacodeccommon.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (15 generated)
sakal
PTAL
4 years, 2 months ago (2016-09-30 12:11:55 UTC) #4
magjed_webrtc
lgtm - easy fix. We should look into if H264 VUI rewriting is broken.
4 years, 2 months ago (2016-09-30 14:37:37 UTC) #7
magjed_webrtc
I would like Alex to review this as well though. Increasing this variable won't increase ...
4 years, 2 months ago (2016-09-30 14:39:00 UTC) #9
sakal
I don't think so. It affects to which point we drain the encoder if it ...
4 years, 2 months ago (2016-09-30 14:44:19 UTC) #10
AlexG
lgtm
4 years, 2 months ago (2016-09-30 17:40:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2382733006/1
4 years, 2 months ago (2016-09-30 17:40:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-09-30 19:41:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2382733006/1
4 years, 2 months ago (2016-10-03 07:32:31 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/15531)
4 years, 2 months ago (2016-10-03 09:15:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2382733006/1
4 years, 2 months ago (2016-10-03 09:31:17 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-03 09:33:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2382733006/1
4 years, 2 months ago (2016-10-03 14:57:45 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 15:07:09 UTC) #27
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 15:07:13 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65b42c251f6dec36e5db44414a10bfa1d092cde9
Cr-Commit-Position: refs/heads/master@{#14479}

Powered by Google App Engine
This is Rietveld 408576698