Remove compat for iOS 7/8

Remove compat for iOS 7/8

BUG=None
R=magjed@webrtc.org, tkchin@webrtc.org

Committed: https://crrev.com/15e4ec334c1fe28142b393d1840665cbc9685a7a
Cr-Commit-Position: refs/heads/master@{#14448}

[kthelgason, 2016-09-29 11:06:55]

kthelgason@webrtc.org changed reviewers:
+ magjed@webrtc.org

[henrika_webrtc, 2016-09-29 11:37:57]

Looks OK. I don't know why that code was ever added in the first place.

[magjed_webrtc, 2016-09-29 11:39:59]

Can you remove the __IPHONE_8_0 check in
webrtc/modules/video_coding/codecs/h264/include/h264.h as well?

https://codereview.webrtc.org/2382713002/diff/1/webrtc/modules/video_capture/...
File webrtc/modules/video_capture/ios/rtc_video_capture_ios_objc.mm (left):

https://codereview.webrtc.org/2382713002/diff/1/webrtc/modules/video_capture/...
webrtc/modules/video_capture/ios/rtc_video_capture_ios_objc.mm:47: #if
defined(__IPHONE_7_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_7_0
It looks like the purpose of this check was to execute the code when the iPhone
OS version >= 7. So remove the check but not the code? If this is untested code,
probably best to speak with henrika@ first.

[magjed_webrtc, 2016-09-29 11:40:12]

Description was changed from

==========
remove compat for iOS 7

BUG=None
==========

to

==========
Remove compat for iOS 7

BUG=None
==========

[tkchin_webrtc, 2016-09-29 11:41:52]

tkchin@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2016-09-29 11:44:46]

On 2016/09/29 11:39:59, magjed_webrtc wrote:
> Can you remove the __IPHONE_8_0 check in
> webrtc/modules/video_coding/codecs/h264/include/h264.h as well?
> 
>
https://codereview.webrtc.org/2382713002/diff/1/webrtc/modules/video_capture/...
> File webrtc/modules/video_capture/ios/rtc_video_capture_ios_objc.mm (left):
> 
>
https://codereview.webrtc.org/2382713002/diff/1/webrtc/modules/video_capture/...
> webrtc/modules/video_capture/ios/rtc_video_capture_ios_objc.mm:47: #if
> defined(__IPHONE_7_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_7_0
> It looks like the purpose of this check was to execute the code when the
iPhone
> OS version >= 7. So remove the check but not the code? If this is untested
code,
> probably best to speak with henrika@ first.

Needs to be set to NO. See:
https://developer.apple.com/reference/avfoundation/avcapturesession/1620490-u...

The compile guards there are present because this API is only present on iOS7
SDK onwards. If you tried to compile using iOS6 SDK it would fail.
The runtime guard is there because you could've compiled using iOS7 SDK but are
running on an iOS6 device.

Since we only care about iOS8+ these days both guards can probably be removed,
though it is harmless to keep the runtime guard.

[kthelgason, 2016-09-29 11:58:35]

Updated.

[magjed_webrtc, 2016-09-29 12:53:23]

lgtm

[magjed_webrtc, 2016-09-29 12:53:31]

Description was changed from

==========
Remove compat for iOS 7

BUG=None
==========

to

==========
Remove compat for iOS 7/8

BUG=None
==========

[kthelgason, 2016-09-29 12:54:16]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2016-09-29 12:54:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 13:36:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 13:36:46]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8799)

[tkchin_webrtc, 2016-09-29 15:09:50]

lgtm

https://codereview.webrtc.org/2382713002/diff/80001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/h264/include/h264.h (right):

https://codereview.webrtc.org/2382713002/diff/80001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/h264/include/h264.h:18: #if
defined(WEBRTC_IOS) || \
can probably clean this up a little - e.g. don't need to include availability if
on ios anymore
but up to you

[kthelgason, 2016-09-29 15:18:15]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2016-09-29 15:18:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 17:19:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 17:19:01]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kthelgason, 2016-09-30 06:56:47]

Description was changed from

==========
Remove compat for iOS 7/8

BUG=None
==========

to

==========
Remove compat for iOS 7/8

BUG=None
R=magjed@webrtc.org, tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/15e4ec334c1fe28142b393d18...
==========

[commit-bot: I haz the power, 2016-09-30 06:56:47]

Description was changed from

==========
Remove compat for iOS 7/8

BUG=None
R=magjed@webrtc.org, tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/15e4ec334c1fe28142b393d18...
==========

to

==========
Remove compat for iOS 7/8

BUG=None
R=magjed@webrtc.org, tkchin@webrtc.org

Committed: https://crrev.com/15e4ec334c1fe28142b393d1840665cbc9685a7a
Cr-Commit-Position: refs/heads/master@{#14448}
==========

[commit-bot: I haz the power, 2016-09-30 06:56:48]

Patchset 5 (id:??) landed as
https://crrev.com/15e4ec334c1fe28142b393d1840665cbc9685a7a
Cr-Commit-Position: refs/heads/master@{#14448}

[kthelgason, 2016-09-30 06:56:48]

Committed patchset #5 (id:80001) manually as
15e4ec334c1fe28142b393d1840665cbc9685a7a (presubmit successful).