Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2381853002: Revert of Unify the macOS and iOS capturer implementations (Closed)

Created:
4 years, 2 months ago by kthelgason
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, mflodman, sdk-team_agora.io
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Unify the macOS and iOS capturer implementations (patchset #4 id:60001 of https://codereview.webrtc.org/2309253005/ ) Reason for revert: Breaks internal project Original issue's description: > Unify the macOS and iOS capturer implementations > > This removes the QTKit based capturer for mac, and removes the need > to link against deprecated system libraries on macOS. > > BUG=webrtc:3968, webrtc:6275, webrtc:6333 > > Committed: https://crrev.com/242d8bdddd77109781cbb70c59d161be7566ac98 > Cr-Commit-Position: refs/heads/master@{#14418} TBR=magjed@webrtc.org,tkchin@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:3968, webrtc:6275, webrtc:6333 Committed: https://crrev.com/eddb7571d81e51a66f4abaf55013c85b4132c837 Cr-Commit-Position: refs/heads/master@{#14429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2429 lines, -967 lines) Patch
M webrtc/modules/video_capture/BUILD.gn View 5 chunks +41 lines, -12 lines 0 comments Download
A webrtc/modules/video_capture/ios/device_info_ios.h View 1 chunk +60 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/ios/device_info_ios.mm View 1 chunk +178 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/ios/device_info_ios_objc.h View 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/ios/device_info_ios_objc.mm View 1 chunk +100 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/ios/rtc_video_capture_ios_objc.h View 1 chunk +39 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/ios/rtc_video_capture_ios_objc.mm View 1 chunk +423 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/ios/video_capture_ios.h View 1 chunk +46 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/ios/video_capture_ios.mm View 1 chunk +106 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit.h View 1 chunk +79 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit.mm View 1 chunk +211 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_info.h View 1 chunk +93 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_info.mm View 1 chunk +125 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_info_objc.h View 1 chunk +67 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_info_objc.mm View 1 chunk +191 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_objc.h View 1 chunk +61 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_objc.mm View 1 chunk +259 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_utility.h View 1 chunk +36 lines, -0 lines 0 comments Download
A webrtc/modules/video_capture/mac/video_capture_mac.mm View 1 chunk +252 lines, -0 lines 0 comments Download
D webrtc/modules/video_capture/objc/device_info.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/modules/video_capture/objc/device_info.mm View 1 chunk +0 lines, -172 lines 0 comments Download
D webrtc/modules/video_capture/objc/device_info_objc.h View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/modules/video_capture/objc/device_info_objc.mm View 1 chunk +0 lines, -91 lines 0 comments Download
D webrtc/modules/video_capture/objc/rtc_video_capture_objc.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/modules/video_capture/objc/rtc_video_capture_objc.mm View 1 chunk +0 lines, -388 lines 0 comments Download
D webrtc/modules/video_capture/objc/video_capture.h View 1 chunk +0 lines, -46 lines 0 comments Download
D webrtc/modules/video_capture/objc/video_capture.mm View 1 chunk +0 lines, -109 lines 0 comments Download
M webrtc/modules/video_capture/video_capture.gypi View 3 chunks +33 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kthelgason
Created Revert of Unify the macOS and iOS capturer implementations
4 years, 2 months ago (2016-09-29 09:42:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2381853002/1
4 years, 2 months ago (2016-09-29 09:43:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 09:43:27 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eddb7571d81e51a66f4abaf55013c85b4132c837 Cr-Commit-Position: refs/heads/master@{#14429}
4 years, 2 months ago (2016-09-29 09:43:31 UTC) #6
kthelgason
4 years, 2 months ago (2016-09-29 09:44:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2375273004/ by kthelgason@webrtc.org.

The reason for reverting is: Internal project has been fixed.

Powered by Google App Engine
This is Rietveld 408576698