Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

Issue 2381833003: Change TWCC send interval to reduce overhead on low BW situations. (Closed)
Patch Set: Change TWCC send interval according to the available bandwidth. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h
diff --git a/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h b/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h
index 127886300d8f95c2fd14d78ebc0ffae9ee5c1094..81a1051cb4c27083ff2ca8372fe77d34ca8c4c90 100644
--- a/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h
+++ b/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h
@@ -12,14 +12,17 @@
#define WEBRTC_MODULES_REMOTE_BITRATE_ESTIMATOR_REMOTE_ESTIMATOR_PROXY_H_
#include <map>
+#include <memory>
#include <vector>
#include "webrtc/base/criticalsection.h"
+#include "webrtc/base/ratetracker.h"
#include "webrtc/modules/include/module_common_types.h"
#include "webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h"
namespace webrtc {
+class BitrateController;
class Clock;
class PacketRouter;
namespace rtcp {
@@ -32,7 +35,9 @@ class TransportFeedback;
class RemoteEstimatorProxy : public RemoteBitrateEstimator {
public:
- RemoteEstimatorProxy(Clock* clock, PacketRouter* packet_router);
+ RemoteEstimatorProxy(Clock* clock,
+ PacketRouter* packet_router,
+ BitrateController* bitrate_controller);
virtual ~RemoteEstimatorProxy();
void IncomingPacketFeedbackVector(
@@ -48,7 +53,9 @@ class RemoteEstimatorProxy : public RemoteBitrateEstimator {
int64_t TimeUntilNextProcess() override;
void Process() override;
- static const int kDefaultProcessIntervalMs;
+ static const int kMinSendIntervalMs;
+ static const int kMaxSendIntervalMs;
+ static const int kMinPacketCountRecievedBitrate;
static const int kBackWindowMs;
private:
@@ -68,6 +75,7 @@ class RemoteEstimatorProxy : public RemoteBitrateEstimator {
int64_t window_start_seq_ GUARDED_BY(&lock_);
// Map unwrapped seq -> time.
std::map<int64_t, int64_t> packet_arrival_times_ GUARDED_BY(&lock_);
+ BitrateController* bitrate_controller_;
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698