|
|
Created:
4 years, 2 months ago by ehmaldonado_webrtc Modified:
4 years, 2 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDisable TCPChannelClientTest.testConnectIPv6
This test is failing because IPv6 is not fully supported on some of the
bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380)
R=kjellander@webrtc.org
TBR=perkj@webrtc.org
BUG=webrtc:6437
NOTRY=True
TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run.
Committed: https://crrev.com/eb5040ae44886af0ce3ed33b5c1dffd20c211f95
Cr-Commit-Position: refs/heads/master@{#14449}
Patch Set 1 #Patch Set 2 : Addressed comments. #
Messages
Total messages: 19 (9 generated)
I guess this could work, but I think it would be better to add //base:base_java_test_support as a dependency to the //webrtc:android_junit_tests target instead. Then we can use the same class as Chromium (and also point devs to the same wiki page)
On 2016/09/30 06:50:47, kjellander_webrtc wrote: > I guess this could work, but I think it would be better to add > //base:base_java_test_support as a dependency to the > //webrtc:android_junit_tests target instead. Then we can use the same class as > Chromium (and also point devs to the same wiki page) PTAL
lgtm assuming you've verified this works. TIP: you can add a TESTED= line to the CL description. It's not a very well established convention but I like to use it myself at least. After that line you just tell what you did to test the CL locally, for the reviewer. Sometimes I find it very useful to have a command line stored there for future reference.
Description was changed from ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org BUG=webrtc:6437 ========== to ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org BUG=webrtc:6437 NOTRY=True ==========
On 2016/09/30 06:57:24, kjellander_webrtc wrote: > lgtm assuming you've verified this works. > > TIP: you can add a TESTED= line to the CL description. It's not a very well > established convention but I like to use it myself at least. After that line you > just tell what you did to test the CL locally, for the reviewer. > Sometimes I find it very useful to have a command line stored there for future > reference. added NOTRY=True
Description was changed from ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org BUG=webrtc:6437 NOTRY=True ========== to ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org BUG=webrtc:6437 TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. ==========
Description was changed from ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org BUG=webrtc:6437 TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. ========== to ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org BUG=webrtc:6437 NOTRY=True TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8824)
Description was changed from ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org BUG=webrtc:6437 NOTRY=True TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. ========== to ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org TBR=perkj@webrtc.org BUG=webrtc:6437 NOTRY=True TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org TBR=perkj@webrtc.org BUG=webrtc:6437 NOTRY=True TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. ========== to ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org TBR=perkj@webrtc.org BUG=webrtc:6437 NOTRY=True TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org TBR=perkj@webrtc.org BUG=webrtc:6437 NOTRY=True TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. ========== to ========== Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org TBR=perkj@webrtc.org BUG=webrtc:6437 NOTRY=True TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. Committed: https://crrev.com/eb5040ae44886af0ce3ed33b5c1dffd20c211f95 Cr-Commit-Position: refs/heads/master@{#14449} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/eb5040ae44886af0ce3ed33b5c1dffd20c211f95 Cr-Commit-Position: refs/heads/master@{#14449} |