Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2381503005: Disable TCPChannelClientTest.testConnectIPv6 (Closed)

Created:
4 years, 2 months ago by ehmaldonado_webrtc
Modified:
4 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable TCPChannelClientTest.testConnectIPv6 This test is failing because IPv6 is not fully supported on some of the bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380) R=kjellander@webrtc.org TBR=perkj@webrtc.org BUG=webrtc:6437 NOTRY=True TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run. Committed: https://crrev.com/eb5040ae44886af0ce3ed33b5c1dffd20c211f95 Cr-Commit-Position: refs/heads/master@{#14449}

Patch Set 1 #

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
ehmaldonado_webrtc
4 years, 2 months ago (2016-09-30 06:34:58 UTC) #1
kjellander_webrtc
I guess this could work, but I think it would be better to add //base:base_java_test_support ...
4 years, 2 months ago (2016-09-30 06:50:47 UTC) #2
ehmaldonado_webrtc
On 2016/09/30 06:50:47, kjellander_webrtc wrote: > I guess this could work, but I think it ...
4 years, 2 months ago (2016-09-30 06:55:25 UTC) #3
kjellander_webrtc
lgtm assuming you've verified this works. TIP: you can add a TESTED= line to the ...
4 years, 2 months ago (2016-09-30 06:57:24 UTC) #4
kjellander_webrtc
On 2016/09/30 06:57:24, kjellander_webrtc wrote: > lgtm assuming you've verified this works. > > TIP: ...
4 years, 2 months ago (2016-09-30 06:59:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2381503005/20001
4 years, 2 months ago (2016-09-30 07:01:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8824)
4 years, 2 months ago (2016-09-30 07:11:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2381503005/20001
4 years, 2 months ago (2016-09-30 07:18:31 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 07:20:09 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 07:20:16 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb5040ae44886af0ce3ed33b5c1dffd20c211f95
Cr-Commit-Position: refs/heads/master@{#14449}

Powered by Google App Engine
This is Rietveld 408576698