Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2381233004: Revert of Use sps and pps to determine decodability of H.264 frames. (Closed)

Created:
4 years, 2 months ago by stefan-webrtc
Modified:
4 years, 2 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, zhengzhonghou_agora.io, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use sps and pps to determine decodability of H.264 frames. (patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ ) Reason for revert: Broke browser_tests, e.g., WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 Original issue's description: > Use sps and pps to determine decodability of H.264 frames. > > NOPRESUBMIT=true > BUG=webrtc:6208 > R=philipel@webrtc.org > > Committed: https://crrev.com/17b02633666f2f5d7e78767ad5674c728d639c26 > Cr-Commit-Position: refs/heads/master@{#14458} TBR=philipel@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6208 Committed: https://crrev.com/3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2 Cr-Commit-Position: refs/heads/master@{#14460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -215 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/decoding_state.h View 3 chunks +0 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/decoding_state.cc View 7 chunks +3 lines, -74 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 4 chunks +4 lines, -88 lines 0 comments Download
M webrtc/modules/video_coding/session_info.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/session_info.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
stefan-webrtc
Created Revert of Use sps and pps to determine decodability of H.264 frames.
4 years, 2 months ago (2016-09-30 16:06:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2381233004/1
4 years, 2 months ago (2016-09-30 16:06:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 16:06:38 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 16:06:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2
Cr-Commit-Position: refs/heads/master@{#14460}

Powered by Google App Engine
This is Rietveld 408576698