Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2380933003: Delete unused support for vp8 partitions. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused support for vp8 partitions. This also makes it possible to drop the RTPFragmentationHeader from the class VCMEncodedFrame. BUG=None Committed: https://crrev.com/6f112cc136bb8da01434747b6b0d0d56f69f271d Cr-Commit-Position: refs/heads/master@{#14455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -590 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 6 chunks +0 lines, -44 lines 0 comments Download
M webrtc/modules/video_coding/encoded_frame.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/encoded_frame.cc View 5 chunks +0 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/session_info.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/session_info.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M webrtc/modules/video_coding/session_info_unittest.cc View 2 chunks +0 lines, -470 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nisse-webrtc
Some questions: Should there be more dangling code to delete here? If VideoDecoder::Decode now always ...
4 years, 2 months ago (2016-09-29 12:29:10 UTC) #2
nisse-webrtc
Replying to myself: On 2016/09/29 12:29:10, nisse-webrtc wrote: > If VideoDecoder::Decode now always get an ...
4 years, 2 months ago (2016-09-29 12:52:20 UTC) #3
stefan-webrtc
lgtm
4 years, 2 months ago (2016-09-30 08:39:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2380933003/1
4 years, 2 months ago (2016-09-30 09:15:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 10:43:03 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 10:43:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f112cc136bb8da01434747b6b0d0d56f69f271d
Cr-Commit-Position: refs/heads/master@{#14455}

Powered by Google App Engine
This is Rietveld 408576698