|
|
Created:
4 years, 2 months ago by honghaiz3 Modified:
4 years, 2 months ago Reviewers:
Taylor Brandstetter CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReplace RelayPort with TurnPort in p2ptransportchannel tests.
Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway.
BUG=None
R=deadbeef@webrtc.org
Committed: https://crrev.com/b73d2697075a4e032cd4f3bd09fcc2a27cd8fd7f
Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Original-Commit-Position: refs/heads/master@{#14441}
Cr-Commit-Position: refs/heads/master@{#14446}
Patch Set 1 : . #
Total comments: 2
Patch Set 2 : Address Taylor's comment #Patch Set 3 : Rebase #Patch Set 4 : Do not have TURN TCP port, which caused some tests flaky #Messages
Total messages: 36 (26 generated)
Description was changed from ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort. BUG=None ========== to ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. BUG=None ==========
Description was changed from ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. BUG=None ========== to ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this are not using RelayPort anyway. BUG=None ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this are not using RelayPort anyway. BUG=None ========== to ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this are not using RelayPort anyway. BUG=None ==========
Description was changed from ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this are not using RelayPort anyway. BUG=None ========== to ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None ==========
The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Replace RelayPort with TurnPort in the p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None ========== to ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
deadbeef@webrtc.org changed reviewers: + deadbeef@webrtc.org
lgtm with nit https://codereview.webrtc.org/2380923002/diff/20001/webrtc/p2p/base/p2ptransp... File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right): https://codereview.webrtc.org/2380923002/diff/20001/webrtc/p2p/base/p2ptransp... webrtc/p2p/base/p2ptransportchannel_unittest.cc:152: allocator->AddTurnServer(turn_server); nit: Could we just call SetConfiguration once at the end, with both STUN and TURN servers?
Description was changed from ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None ========== to ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None ==========
https://codereview.webrtc.org/2380923002/diff/20001/webrtc/p2p/base/p2ptransp... File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right): https://codereview.webrtc.org/2380923002/diff/20001/webrtc/p2p/base/p2ptransp... webrtc/p2p/base/p2ptransportchannel_unittest.cc:152: allocator->AddTurnServer(turn_server); On 2016/09/29 16:47:51, Taylor Brandstetter wrote: > nit: Could we just call SetConfiguration once at the end, with both STUN and > TURN servers? Done. Good point.
The CQ bit was checked by honghaiz@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org Link to the patchset: https://codereview.webrtc.org/2380923002/#ps40001 (title: "Address Taylor's comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None ========== to ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c8d21712dde64c7d613d1ea56... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as c8d21712dde64c7d613d1ea56c840438505a909f (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c8d21712dde64c7d613d1ea56... ========== to ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f Cr-Commit-Position: refs/heads/master@{#14441} ==========
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.webrtc.org/2385563002/ by honghaiz@webrtc.org. The reason for reverting is: It caused some tests in p2ptransportchannel flaky. .
Message was sent while issue was closed.
Description was changed from ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f Cr-Commit-Position: refs/heads/master@{#14441} ========== to ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f Cr-Commit-Position: refs/heads/master@{#14441} ==========
The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by honghaiz@webrtc.org
The CQ bit was checked by honghaiz@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org Link to the patchset: https://codereview.webrtc.org/2380923002/#ps80001 (title: "Do not have TURN TCP port, which caused some tests flaky")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f Cr-Commit-Position: refs/heads/master@{#14441} ========== to ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f Cr-Commit-Position: refs/heads/master@{#14441} Committed: https://chromium.googlesource.com/external/webrtc/+/b73d2697075a4e032cd4f3bd0... ==========
Description was changed from ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f Cr-Commit-Position: refs/heads/master@{#14441} Committed: https://chromium.googlesource.com/external/webrtc/+/b73d2697075a4e032cd4f3bd0... ========== to ========== Replace RelayPort with TurnPort in p2ptransportchannel tests. Also remove the relay servers in the tests. Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. BUG=None R=deadbeef@webrtc.org Committed: https://crrev.com/b73d2697075a4e032cd4f3bd09fcc2a27cd8fd7f Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f Cr-Original-Commit-Position: refs/heads/master@{#14441} Cr-Commit-Position: refs/heads/master@{#14446} ==========
Committed patchset #4 (id:80001) manually as b73d2697075a4e032cd4f3bd09fcc2a27cd8fd7f (presubmit successful).
Patchset 4 (id:??) landed as https://crrev.com/b73d2697075a4e032cd4f3bd09fcc2a27cd8fd7f Cr-Commit-Position: refs/heads/master@{#14446} |