Replace RelayPort with TurnPort in p2ptransportchannel tests.

Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed: https://crrev.com/b73d2697075a4e032cd4f3bd09fcc2a27cd8fd7f
Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Original-Commit-Position: refs/heads/master@{#14441}
Cr-Commit-Position: refs/heads/master@{#14446}

[honghaiz3, 2016-09-29 02:37:23]

Description was changed from

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort.

BUG=None
==========

to

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort.

BUG=None
==========

[honghaiz3, 2016-09-29 02:40:12]

Description was changed from

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort.

BUG=None
==========

to

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this are not using RelayPort anyway.

BUG=None
==========

[honghaiz3, 2016-09-29 02:40:20]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-09-29 02:40:36]

Description was changed from

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this are not using RelayPort anyway.

BUG=None
==========

to

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.
Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this are not using RelayPort anyway.

BUG=None
==========

[honghaiz3, 2016-09-29 02:41:49]

Description was changed from

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.
Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this are not using RelayPort anyway.

BUG=None
==========

to

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.
Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
==========

[honghaiz3, 2016-09-29 02:42:41]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 02:42:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[honghaiz3, 2016-09-29 02:50:44]

Description was changed from

==========
Replace RelayPort with TurnPort in the p2ptransportchannel tests.
Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
==========

to

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.
Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
==========

[commit-bot: I haz the power, 2016-09-29 04:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 04:15:29]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2016-09-29 16:47:50]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2016-09-29 16:47:51]

lgtm with nit

https://codereview.webrtc.org/2380923002/diff/20001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right):

https://codereview.webrtc.org/2380923002/diff/20001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel_unittest.cc:152:
allocator->AddTurnServer(turn_server);
nit: Could we just call SetConfiguration once at the end, with both STUN and
TURN servers?

[Taylor Brandstetter, 2016-09-29 16:48:07]

Description was changed from

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.
Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
==========

to

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
==========

[honghaiz3, 2016-09-29 17:18:58]

https://codereview.webrtc.org/2380923002/diff/20001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel_unittest.cc (right):

https://codereview.webrtc.org/2380923002/diff/20001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel_unittest.cc:152:
allocator->AddTurnServer(turn_server);
On 2016/09/29 16:47:51, Taylor Brandstetter wrote:
> nit: Could we just call SetConfiguration once at the end, with both STUN and
> TURN servers?

Done. Good point.

[honghaiz3, 2016-09-29 17:19:01]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-09-29 17:19:02]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2380923002/#ps40001 (title:
"Address Taylor's comment")

[commit-bot: I haz the power, 2016-09-29 17:19:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 19:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 19:19:43]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[honghaiz3, 2016-09-29 21:51:40]

Description was changed from

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
==========

to

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c8d21712dde64c7d613d1ea56...
==========

[honghaiz3, 2016-09-29 21:51:41]

Committed patchset #2 (id:40001) manually as
c8d21712dde64c7d613d1ea56c840438505a909f (presubmit successful).

[commit-bot: I haz the power, 2016-09-29 21:51:43]

Description was changed from

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c8d21712dde64c7d613d1ea56...
==========

to

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Commit-Position: refs/heads/master@{#14441}
==========

[honghaiz3, 2016-09-30 01:17:05]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.webrtc.org/2385563002/ by honghaiz@webrtc.org.

The reason for reverting is: It caused some tests in p2ptransportchannel flaky.
.

[honghaiz3, 2016-09-30 01:23:45]

Description was changed from

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Commit-Position: refs/heads/master@{#14441}
==========

to

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Commit-Position: refs/heads/master@{#14441}
==========

[honghaiz3, 2016-09-30 01:34:48]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 01:34:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[honghaiz3, 2016-09-30 02:21:15]

The CQ bit was unchecked by honghaiz@webrtc.org

[honghaiz3, 2016-09-30 02:21:23]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-09-30 02:21:23]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2380923002/#ps80001 (title:
"Do not have TURN TCP port, which caused some tests flaky")

[commit-bot: I haz the power, 2016-09-30 02:21:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-30 03:35:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 03:35:35]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[honghaiz3, 2016-09-30 05:46:20]

Description was changed from

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Commit-Position: refs/heads/master@{#14441}
==========

to

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Commit-Position: refs/heads/master@{#14441}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b73d2697075a4e032cd4f3bd0...
==========

[commit-bot: I haz the power, 2016-09-30 05:46:20]

Description was changed from

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Commit-Position: refs/heads/master@{#14441}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b73d2697075a4e032cd4f3bd0...
==========

to

==========
Replace RelayPort with TurnPort in p2ptransportchannel tests.

Also remove the relay servers in the tests.
Most of the code and the downstream apps are using TurnPort, not RelayPort. Most
of the tests in this file are not using RelayPort anyway.

BUG=None
R=deadbeef@webrtc.org

Committed: https://crrev.com/b73d2697075a4e032cd4f3bd09fcc2a27cd8fd7f
Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f
Cr-Original-Commit-Position: refs/heads/master@{#14441}
Cr-Commit-Position: refs/heads/master@{#14446}
==========

[honghaiz3, 2016-09-30 05:46:21]

Committed patchset #4 (id:80001) manually as
b73d2697075a4e032cd4f3bd09fcc2a27cd8fd7f (presubmit successful).

[commit-bot: I haz the power, 2016-09-30 05:46:21]

Patchset 4 (id:??) landed as
https://crrev.com/b73d2697075a4e032cd4f3bd09fcc2a27cd8fd7f
Cr-Commit-Position: refs/heads/master@{#14446}