webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h - Issue 2380883003: Add interval estimator to remote bitrate estimator

Unified Diff: webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h

Issue 2380883003: Add interval estimator to remote bitrate estimator (Closed)

Patch Set: Respond to comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h

diff --git a/webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h b/webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h

index 2b2e85bf911b0b16b80f092f78919a3b31c964c3..cae106c785bfa2d212ec23a58209d071f805e43c 100644

--- a/webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h

+++ b/webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h

@@ -42,6 +42,8 @@ class AimdRateControl {

void SetRtt(int64_t rtt);

void Update(const RateControlInput* input, int64_t now_ms);

void SetEstimate(int bitrate_bps, int64_t now_ms);

+ virtual int GetNearMaxIncreaseRateBps() const;

minyue-webrtc 2016/11/14 16:50:42 why virtual? Does "Near" mean "Latest"? I feel th

michaelt 2016/11/15 09:41:59 The function is virtual so that I can mock them.

minyue-webrtc 2016/11/15 12:20:35 ah, right.

+ virtual rtc::Optional<int> GetLastDecrease() const;

minyue-webrtc 2016/11/14 16:50:42 why virtual? and the name may be made clearer: ho

michaelt 2016/11/15 09:41:59 The function is virtual so that I can mock them.

minyue-webrtc 2016/11/15 12:20:35 Acknowledged.

private:

// Update the target bitrate according based on, among other things,

@@ -56,8 +58,7 @@ class AimdRateControl {

int64_t now_ms);

uint32_t MultiplicativeRateIncrease(int64_t now_ms, int64_t last_ms,

uint32_t current_bitrate_bps) const;

- uint32_t AdditiveRateIncrease(int64_t now_ms, int64_t last_ms,

- int64_t response_time_ms) const;

+ uint32_t AdditiveRateIncrease(int64_t now_ms, int64_t last_ms) const;

void UpdateChangePeriod(int64_t now_ms);

void UpdateMaxBitRateEstimate(float incoming_bit_rate_kbps);

void ChangeState(const RateControlInput& input, int64_t now_ms);

@@ -79,6 +80,7 @@ class AimdRateControl {

float beta_;

int64_t rtt_;

bool in_experiment_;

+ rtc::Optional<int> last_decrease_;

};

} // namespace webrtc