Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2380623002: Delete method webrtc::VideoFrame::allocated_size and enum PlaneType. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete method webrtc::VideoFrame::allocated_size and enum PlaneType. BUG=webrtc:5682 Committed: https://crrev.com/e5684c5387bbc2cbbca80eefc3e3f6474c180647 Cr-Commit-Position: refs/heads/master@{#14416}

Patch Set 1 #

Patch Set 2 : Fix H264DecoderImpl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -73 lines) Patch
M webrtc/common_video/i420_video_frame_unittest.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M webrtc/common_video/include/video_frame_buffer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/test/frame_generator_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nisse-webrtc
Continued cleanup of webrtc::VideoFrame. Not sure how far we'll get, but other methods on the ...
4 years, 2 months ago (2016-09-28 07:27:05 UTC) #2
stefan-webrtc
lgtm
4 years, 2 months ago (2016-09-28 07:28:17 UTC) #3
magjed_webrtc
lgtm
4 years, 2 months ago (2016-09-28 09:11:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2380623002/40001
4 years, 2 months ago (2016-09-28 09:11:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-09-28 10:14:10 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 10:14:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5684c5387bbc2cbbca80eefc3e3f6474c180647
Cr-Commit-Position: refs/heads/master@{#14416}

Powered by Google App Engine
This is Rietveld 408576698