Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2380533002: Roll chromium_revision f86fb54ec3..dd442d4812 (420104:421425) (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, mattdr-at-webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision f86fb54ec3..dd442d4812 (420104:421425) Add a copy of Chromium's build/common.gypi @ fa8868418ffe9da48614de5bff07b72f97760f51 as webrtc/build/chromium_common.gypi to preserve GYP behavior. Update webrtc/build/gyp_webrtc.py to include it during GYP invocation. Change log: https://chromium.googlesource.com/chromium/src/+log/f86fb54ec3..dd442d4812 Full diff: https://chromium.googlesource.com/chromium/src/+/f86fb54ec3..dd442d4812 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/57649e5e20..86f7e41d94 * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/ed6c5d3910..0d81373f91 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/48bdd208dc..b17c065a8a * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/4282d29355..99ef84c65a DEPS diff: https://chromium.googlesource.com/chromium/src/+/f86fb54ec3..dd442d4812/DEPS Clang version changed 280836:282487 Details: https://chromium.googlesource.com/chromium/src/+/f86fb54ec3..dd442d4812/tools/clang/scripts/update.py TBR=marpan@webrtc.org, BUG=None NOTRY=True Committed: https://crrev.com/f363d147d771b16cff59a274f719ea097989bc0e Cr-Commit-Position: refs/heads/master@{#14409}

Patch Set 1 #

Patch Set 2 : Add GetOutputDirectory function for Windows #

Patch Set 3 : Fixed PyLint complaints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6029 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/build/chromium_common.gypi View 1 chunk +5973 lines, -0 lines 0 comments Download
M webrtc/build/gyp_webrtc.py View 1 2 4 chunks +55 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
kjellander_webrtc
Finally! Another survival-CL for GYP :)
4 years, 2 months ago (2016-09-28 06:35:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2380533002/60001
4 years, 2 months ago (2016-09-28 06:35:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8740)
4 years, 2 months ago (2016-09-28 06:55:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2380533002/80001
4 years, 2 months ago (2016-09-28 07:12:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8743)
4 years, 2 months ago (2016-09-28 07:25:42 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f363d147d771b16cff59a274f719ea097989bc0e Cr-Commit-Position: refs/heads/master@{#14409}
4 years, 2 months ago (2016-09-28 07:45:18 UTC) #16
kjellander_webrtc
4 years, 2 months ago (2016-09-28 07:45:19 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:80001) manually as
f363d147d771b16cff59a274f719ea097989bc0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698