Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2380463003: Move FunctionView from AudioCodingModule to the rtc namespace (Closed)

Created:
4 years, 2 months ago by kwiberg-webrtc
Modified:
4 years, 2 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move FunctionView from AudioCodingModule to the rtc namespace It's a very general type, and we're about to start needing it in other places besides AudioCodingModule. BUG=webrtc:5801 Committed: https://crrev.com/24c7c1238debd97ec580611800a90888f5c43a88 Cr-Commit-Position: refs/heads/master@{#14423}

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -43 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/base/function_view.h View 1 chunk +70 lines, -0 lines 0 comments Download
A webrtc/base/function_view_unittest.cc View 1 1 chunk +146 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/include/audio_coding_module.h View 3 chunks +5 lines, -34 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
I decided to punt on function pointer support; I think I know how exactly to ...
4 years, 2 months ago (2016-09-28 10:48:45 UTC) #2
ossu
Agreed. It's not critical to get bogged down by that use-case right now. LGTM!
4 years, 2 months ago (2016-09-28 13:47:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2380463003/20001
4 years, 2 months ago (2016-09-28 16:51:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 18:57:16 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 18:57:25 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24c7c1238debd97ec580611800a90888f5c43a88
Cr-Commit-Position: refs/heads/master@{#14423}

Powered by Google App Engine
This is Rietveld 408576698