Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2378113002: Allow max 1 block per type in RTCP Extended Reports (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow max 1 block per type in RTCP Extended Reports Design of individual block in ExtendedReports packet suggest there is no point to have more than one block per type. This CL reduce complexity of having several blocks of the same type in same report. BUG=webrtc:5260 Committed: https://crrev.com/80ac24dd36b2df1c0faee5ae490b9a74db9c7464 Cr-Commit-Position: refs/heads/master@{#14855}

Patch Set 1 #

Patch Set 2 : Use Optional reset/emplace #

Patch Set 3 : Undo unrelated changes #

Patch Set 4 : nits #

Patch Set 5 : use operator==(T, Optional<T>) for slightly cleaner tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -296 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc View 1 3 chunks +6 lines, -14 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h View 1 5 chunks +14 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.cc View 1 2 3 5 chunks +37 lines, -46 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports_unittest.cc View 1 2 3 4 8 chunks +28 lines, -112 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 14 chunks +23 lines, -36 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 3 chunks +3 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 2 3 3 chunks +32 lines, -32 lines 0 comments Download
M webrtc/test/rtcp_packet_parser.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
danilchap
4 years, 2 months ago (2016-10-20 08:33:46 UTC) #7
sprang_webrtc
lgtm
4 years, 1 month ago (2016-10-25 08:11:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2378113002/180001
4 years, 1 month ago (2016-10-25 08:50:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9509)
4 years, 1 month ago (2016-10-25 08:52:12 UTC) #12
danilchap
Stefan, can you approve a change in /test/
4 years, 1 month ago (2016-10-25 08:58:56 UTC) #15
stefan-webrtc
lgtm
4 years, 1 month ago (2016-10-31 15:10:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2378113002/180001
4 years, 1 month ago (2016-10-31 15:11:36 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:180001)
4 years, 1 month ago (2016-10-31 15:40:50 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 15:44:29 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/80ac24dd36b2df1c0faee5ae490b9a74db9c7464
Cr-Commit-Position: refs/heads/master@{#14855}

Powered by Google App Engine
This is Rietveld 408576698