Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2378003002: Delete webrtc::VideoFrame::CreateEmptyFrame. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete webrtc::VideoFrame::CreateEmptyFrame. BUG=webrtc:5682 Committed: https://crrev.com/f122a852874d99170281f4042b9af9f51657c4d4 Cr-Commit-Position: refs/heads/master@{#14512}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebased. #

Patch Set 3 : Added size_t/int cast, needed for windows 64-bit builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -97 lines) Patch
M webrtc/common_video/i420_video_frame_unittest.cc View 1 4 chunks +4 lines, -27 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/test/fake_decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/fake_decoder.cc View 1 2 chunks +6 lines, -11 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 2 5 chunks +8 lines, -10 lines 0 comments Download
M webrtc/video/overuse_frame_detector_unittest.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 28 (12 generated)
nisse-webrtc
Next method to go in webrtc::VideoFrame.
4 years, 2 months ago (2016-09-28 11:22:02 UTC) #2
magjed_webrtc
https://codereview.webrtc.org/2378003002/diff/1/webrtc/common_video/i420_video_frame_unittest.cc File webrtc/common_video/i420_video_frame_unittest.cc (right): https://codereview.webrtc.org/2378003002/diff/1/webrtc/common_video/i420_video_frame_unittest.cc#newcode114 webrtc/common_video/i420_video_frame_unittest.cc:114: VideoFrame small_frame; Don't you need to create an I420Buffer ...
4 years, 2 months ago (2016-09-28 14:03:04 UTC) #3
nisse-webrtc
https://codereview.webrtc.org/2378003002/diff/1/webrtc/common_video/i420_video_frame_unittest.cc File webrtc/common_video/i420_video_frame_unittest.cc (right): https://codereview.webrtc.org/2378003002/diff/1/webrtc/common_video/i420_video_frame_unittest.cc#newcode114 webrtc/common_video/i420_video_frame_unittest.cc:114: VideoFrame small_frame; On 2016/09/28 14:03:04, magjed_webrtc wrote: > Don't ...
4 years, 2 months ago (2016-09-29 06:32:44 UTC) #4
stefan-webrtc
lgtm once magjed is pleased.
4 years, 2 months ago (2016-09-29 14:47:37 UTC) #5
magjed_webrtc
lgtm https://codereview.webrtc.org/2378003002/diff/1/webrtc/common_video/i420_video_frame_unittest.cc File webrtc/common_video/i420_video_frame_unittest.cc (right): https://codereview.webrtc.org/2378003002/diff/1/webrtc/common_video/i420_video_frame_unittest.cc#newcode114 webrtc/common_video/i420_video_frame_unittest.cc:114: VideoFrame small_frame; On 2016/09/29 06:32:44, nisse-webrtc wrote: > ...
4 years, 2 months ago (2016-09-29 15:39:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2378003002/1
4 years, 2 months ago (2016-09-30 06:38:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/1726)
4 years, 2 months ago (2016-09-30 07:11:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2378003002/40001
4 years, 2 months ago (2016-09-30 13:05:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-09-30 15:06:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2378003002/40001
4 years, 2 months ago (2016-10-03 06:23:33 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/6913) win_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 2 months ago (2016-10-03 07:48:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2378003002/40001
4 years, 2 months ago (2016-10-04 06:57:12 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-04 10:24:52 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2378003002/40001
4 years, 2 months ago (2016-10-05 06:17:19 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 06:27:33 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 06:27:42 UTC) #28
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f122a852874d99170281f4042b9af9f51657c4d4
Cr-Commit-Position: refs/heads/master@{#14512}

Powered by Google App Engine
This is Rietveld 408576698