Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2376753003: GN: Fix incorrect include_dir for libjingle_peerconnection_jni target (Closed)

Created:
4 years, 2 months ago by charujain
Modified:
4 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix incorrect include_dir for libjingle_peerconnection_jni target BUG=webrtc:6412 NOTRY=True Committed: https://crrev.com/b7446d71013a6e2c925fe8f423ceb44f07088c87 Cr-Commit-Position: refs/heads/master@{#14410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/api/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
kjellander_webrtc
lgtm I added BUG= for you. Feel free to commit if the bots I triggered ...
4 years, 2 months ago (2016-09-27 19:09:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2376753003/1
4 years, 2 months ago (2016-09-28 07:40:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 07:47:54 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 07:48:03 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b7446d71013a6e2c925fe8f423ceb44f07088c87
Cr-Commit-Position: refs/heads/master@{#14410}

Powered by Google App Engine
This is Rietveld 408576698