Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2375603002: GN: Fix incorrect include_dir for video_coding on iOS (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
Reviewers:
charujain
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix incorrect include_dir for video_coding on iOS When rtc_build_libyuv=false an incorrect code path is surfaced in GN. BUG=webrtc:6412 NOTRY=True TESTED=gn gen out/foo --args='rtc_build_libyuv=false target_os="ios"' Committed: https://crrev.com/4ecd9700eec58095db1934fbadcdceebdd6288f8 Cr-Commit-Position: refs/heads/master@{#14392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 2 months ago (2016-09-27 07:07:38 UTC) #3
charujain
lgtm
4 years, 2 months ago (2016-09-27 07:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2375603002/1
4 years, 2 months ago (2016-09-27 07:59:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 08:11:21 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 08:11:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ecd9700eec58095db1934fbadcdceebdd6288f8
Cr-Commit-Position: refs/heads/master@{#14392}

Powered by Google App Engine
This is Rietveld 408576698