Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Unified Diff: webrtc/stats/rtcstatsreport_unittest.cc

Issue 2373503002: rtc_stats: Update code to remove chromium style warnings suppression. (Closed)
Patch Set: Updated comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/stats/rtcstatsreport_unittest.cc
diff --git a/webrtc/stats/rtcstatsreport_unittest.cc b/webrtc/stats/rtcstatsreport_unittest.cc
index 9a0bb1a125a2439d6d41542ff63db6f2c9316f19..3bfbd44cba626b6c6accb1a16b598ae3209d0930 100644
--- a/webrtc/stats/rtcstatsreport_unittest.cc
+++ b/webrtc/stats/rtcstatsreport_unittest.cc
@@ -18,45 +18,45 @@ namespace webrtc {
class RTCTestStats1 : public RTCStats {
public:
+ WEBRTC_RTCSTATS_DECL();
+
RTCTestStats1(const std::string& id, int64_t timestamp_us)
: RTCStats(id, timestamp_us),
integer("integer") {}
- WEBRTC_RTCSTATS_IMPL(RTCStats, RTCTestStats1,
- &integer);
-
RTCStatsMember<int32_t> integer;
};
-const char RTCTestStats1::kType[] = "test-stats-1";
+WEBRTC_RTCSTATS_IMPL(RTCTestStats1, RTCStats, "test-stats-1",
+ &integer);
class RTCTestStats2 : public RTCStats {
public:
+ WEBRTC_RTCSTATS_DECL();
+
RTCTestStats2(const std::string& id, int64_t timestamp_us)
: RTCStats(id, timestamp_us),
number("number") {}
- WEBRTC_RTCSTATS_IMPL(RTCStats, RTCTestStats2,
- &number);
-
RTCStatsMember<double> number;
};
-const char RTCTestStats2::kType[] = "test-stats-2";
+WEBRTC_RTCSTATS_IMPL(RTCTestStats2, RTCStats, "test-stats-2",
+ &number);
class RTCTestStats3 : public RTCStats {
public:
+ WEBRTC_RTCSTATS_DECL();
+
RTCTestStats3(const std::string& id, int64_t timestamp_us)
: RTCStats(id, timestamp_us),
string("string") {}
- WEBRTC_RTCSTATS_IMPL(RTCStats, RTCTestStats3,
- &string);
-
RTCStatsMember<std::string> string;
};
-const char RTCTestStats3::kType[] = "test-stats-3";
+WEBRTC_RTCSTATS_IMPL(RTCTestStats3, RTCStats, "test-stats-3",
+ &string);
TEST(RTCStatsReport, AddAndGetStats) {
rtc::scoped_refptr<RTCStatsReport> report = RTCStatsReport::Create();

Powered by Google App Engine
This is Rietveld 408576698