Support for parsing CABAC coded bitstreams

Support for parsing CABAC coded bitstreams

Remove check on entropy_coding_mode_flag in PPS parser.
Parse entropy_coding_mode_flag from PPS and store it in the parser struct. Parse out extra data in NALU slices in case of entropy_coding_mode to avoid reporting incorrect QP.

BUG=webrtc:6338
Committed: https://crrev.com/d020f3fea0deef136b6b381383c6aa6879bb7b38
Cr-Commit-Position: refs/heads/master@{#14522}

[kthelgason, 2016-09-28 14:46:35]

kthelgason@webrtc.org changed reviewers:
+ magjed@webrtc.org, stefan@webrtc.org

[kthelgason, 2016-09-28 14:46:35]

Small CL, should be quick :)

[magjed_webrtc, 2016-09-28 15:13:01]

https://codereview.webrtc.org/2373393002/diff/1/webrtc/common_video/h264/pps_...
File webrtc/common_video/h264/pps_parser.cc (right):

https://codereview.webrtc.org/2373393002/diff/1/webrtc/common_video/h264/pps_...
webrtc/common_video/h264/pps_parser.cc:85: pps.entropy_coding_mode_flag =
!!entropy_coding_mode_flag;
nit: !! is cute, but I would prefer != 0. I don't think the style guide mentions
this. I don't want to enforce my subjective style, so ignore this comment if you
want.

[magjed_webrtc, 2016-09-28 15:13:05]

lgtm

[kthelgason, 2016-09-30 12:59:12]

Description was changed from

==========
Remove check on entropy_coding_mode_flag in PPS parser.

Also parse entropy_coding_mode_flag from PPS.

BUG=webrtc:6338
==========

to

==========
Support for parsing CABAC coded bitstreams

Remove check on entropy_coding_mode_flag in PPS parser.
Parse entropy_coding_mode_flag from PPS and store it in the parser struct. Parse
out extra data in NALU slices in case of entropy_coding_mode to avoid reporting
incorrect QP.


BUG=webrtc:6338
==========

[kthelgason, 2016-09-30 13:04:56]

We were assuming CAVLC in the bitstream_parser as well. This new patchset
removes that assumption.

[stefan-webrtc, 2016-09-30 13:33:09]

lgtm % nits

https://codereview.webrtc.org/2373393002/diff/20001/webrtc/common_video/h264/...
File webrtc/common_video/h264/pps_parser.cc (right):

https://codereview.webrtc.org/2373393002/diff/20001/webrtc/common_video/h264/...
webrtc/common_video/h264/pps_parser.cc:85: pps.entropy_coding_mode_flag =
!!entropy_coding_mode_flag;
I'd also prefer != 0.

https://codereview.webrtc.org/2373393002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/utility/h264_bitstream_parser_unittest.cc
(right):

https://codereview.webrtc.org/2373393002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/utility/h264_bitstream_parser_unittest.cc:35:
uint8_t kH264BitstreamChunkCABAC[] = {
s/CABAC/Cabac/

[kthelgason, 2016-09-30 14:09:48]

Updated the test data to something that I've verified with external tools.

https://codereview.webrtc.org/2373393002/diff/20001/webrtc/common_video/h264/...
File webrtc/common_video/h264/pps_parser.cc (right):

https://codereview.webrtc.org/2373393002/diff/20001/webrtc/common_video/h264/...
webrtc/common_video/h264/pps_parser.cc:85: pps.entropy_coding_mode_flag =
!!entropy_coding_mode_flag;
On 2016/09/30 13:33:09, stefan-webrtc (holmer) wrote:
> I'd also prefer != 0.

You guys are no fun :(

[magjed_webrtc, 2016-09-30 14:34:22]

Still lgtm

[kthelgason, 2016-10-03 07:29:26]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2016-10-03 07:29:26]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2373393002/#ps40001 (title:
"update test data")

[commit-bot: I haz the power, 2016-10-03 07:29:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-03 08:10:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 08:10:44]

Try jobs failed on following builders:
  win_drmemory_light on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/buil...)

[kthelgason, 2016-10-03 09:05:49]

Patchset #3 (id:40001) has been deleted

[kthelgason, 2016-10-05 07:16:29]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2016-10-05 07:16:29]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2373393002/#ps60001 (title:
"update test data")

[commit-bot: I haz the power, 2016-10-05 07:16:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 09:16:24]

Description was changed from

==========
Support for parsing CABAC coded bitstreams

Remove check on entropy_coding_mode_flag in PPS parser.
Parse entropy_coding_mode_flag from PPS and store it in the parser struct. Parse
out extra data in NALU slices in case of entropy_coding_mode to avoid reporting
incorrect QP.


BUG=webrtc:6338
==========

to

==========
Support for parsing CABAC coded bitstreams

Remove check on entropy_coding_mode_flag in PPS parser.
Parse entropy_coding_mode_flag from PPS and store it in the parser struct. Parse
out extra data in NALU slices in case of entropy_coding_mode to avoid reporting
incorrect QP.


BUG=webrtc:6338
==========

[commit-bot: I haz the power, 2016-10-05 09:16:25]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-05 09:16:32]

Description was changed from

==========
Support for parsing CABAC coded bitstreams

Remove check on entropy_coding_mode_flag in PPS parser.
Parse entropy_coding_mode_flag from PPS and store it in the parser struct. Parse
out extra data in NALU slices in case of entropy_coding_mode to avoid reporting
incorrect QP.


BUG=webrtc:6338
==========

to

==========
Support for parsing CABAC coded bitstreams

Remove check on entropy_coding_mode_flag in PPS parser.
Parse entropy_coding_mode_flag from PPS and store it in the parser struct. Parse
out extra data in NALU slices in case of entropy_coding_mode to avoid reporting
incorrect QP.

BUG=webrtc:6338

Committed: https://crrev.com/d020f3fea0deef136b6b381383c6aa6879bb7b38
Cr-Commit-Position: refs/heads/master@{#14522}
==========

[commit-bot: I haz the power, 2016-10-05 09:16:33]

Patchset 3 (id:??) landed as
https://crrev.com/d020f3fea0deef136b6b381383c6aa6879bb7b38
Cr-Commit-Position: refs/heads/master@{#14522}