Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1877)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_receiver.h

Issue 2373053002: Move RTCPHelp::RTCPReceiveInformation inside RTCPReceiver (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h b/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
index 0fbcdbcc6de40e0c035b01b016a566bf9dc486a2..51e9399d7d70d3ad24450094b1b745be580e3c49 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_receiver.h
@@ -101,7 +101,7 @@ class RTCPReceiver {
// returns true once until a new RR is received.
bool RtcpRrSequenceNumberTimeout(int64_t rtcp_interval_ms);
- std::vector<rtcp::TmmbItem> TmmbrReceived() const;
+ std::vector<rtcp::TmmbItem> TmmbrReceived();
bool UpdateRTCPReceiveInformationTimers();
@@ -114,7 +114,9 @@ class RTCPReceiver {
private:
struct PacketInformation;
- using ReceivedInfoMap = std::map<uint32_t, RTCPHelp::RTCPReceiveInformation*>;
+ struct ReceiveInformation;
+ // Mapped by remote ssrc.
+ using ReceivedInfoMap = std::map<uint32_t, ReceiveInformation>;
// RTCP report block information mapped by remote SSRC.
using ReportBlockInfoMap =
std::map<uint32_t, RTCPHelp::RTCPReportBlockInformation*>;
@@ -128,9 +130,10 @@ class RTCPReceiver {
void TriggerCallbacksFromRTCPPacket(
const PacketInformation& packet_information);
- RTCPHelp::RTCPReceiveInformation* CreateReceiveInformation(
- uint32_t remoteSSRC);
- RTCPHelp::RTCPReceiveInformation* GetReceiveInformation(uint32_t remoteSSRC);
+ void CreateReceiveInformation(uint32_t remote_ssrc)
+ EXCLUSIVE_LOCKS_REQUIRED(_criticalSectionRTCPReceiver);
+ ReceiveInformation* GetReceiveInformation(uint32_t remote_ssrc)
+ EXCLUSIVE_LOCKS_REQUIRED(_criticalSectionRTCPReceiver);
void HandleSenderReport(const rtcp::CommonHeader& rtcp_block,
PacketInformation* packet_information)
@@ -244,7 +247,7 @@ class RTCPReceiver {
// Received report blocks.
ReportBlockMap _receivedReportBlockMap
GUARDED_BY(_criticalSectionRTCPReceiver);
- ReceivedInfoMap _receivedInfoMap;
+ ReceivedInfoMap received_infos_ GUARDED_BY(_criticalSectionRTCPReceiver);
std::map<uint32_t, std::string> received_cnames_
GUARDED_BY(_criticalSectionRTCPReceiver);
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698