Chromium Code Reviews

Issue 2373003002: Delete unused file versionparsing.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused file versionparsing.h. BUG=webrtc:6424 Committed: https://crrev.com/2de66fe1c96eb719c1f38506bcc9f0c398bb6f62 Cr-Commit-Position: refs/heads/master@{#14510}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Stats (+0 lines, -171 lines)
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments
D webrtc/base/versionparsing.h View 1 chunk +0 lines, -35 lines 0 comments
D webrtc/base/versionparsing.cc View 1 chunk +0 lines, -57 lines 0 comments
D webrtc/base/versionparsing_unittest.cc View 1 chunk +0 lines, -74 lines 0 comments

Messages

Total messages: 19 (10 generated)
nisse-webrtc
4 years, 2 months ago (2016-09-27 07:28:16 UTC) #2
pthatcher1
lgtm
4 years, 2 months ago (2016-10-03 23:12:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2373003002/1
4 years, 2 months ago (2016-10-04 07:46:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/14941)
4 years, 2 months ago (2016-10-04 07:48:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2373003002/20001
4 years, 2 months ago (2016-10-04 08:16:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 2 months ago (2016-10-04 10:16:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2373003002/20001
4 years, 2 months ago (2016-10-05 06:17:48 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 06:25:01 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 06:25:13 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2de66fe1c96eb719c1f38506bcc9f0c398bb6f62
Cr-Commit-Position: refs/heads/master@{#14510}

Powered by Google App Engine