Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2092)

Issue 2372203002: Add usage description strings to Info.plist (Closed)

Created:
4 years, 2 months ago by kthelgason
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add usage description strings to Info.plist These are required for apps that use the camera and microphone on iOS 10 BUG=webrtc:6428 R=magjed@webrtc.org, tkchin@webrtc.org Committed: https://crrev.com/41514718a8cf326f4ae3d68e54ca8614d2e527a5 Cr-Commit-Position: refs/heads/master@{#14401}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Altered message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/examples/objc/AppRTCMobile/ios/Info.plist View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
kthelgason
PTAL
4 years, 2 months ago (2016-09-27 11:41:25 UTC) #3
henrika_webrtc
Could you make an isolated change where the diff is more clear? Thanks.
4 years, 2 months ago (2016-09-27 11:43:10 UTC) #4
henrika_webrtc
Also, isn't the name now AppRTCMobile?
4 years, 2 months ago (2016-09-27 11:44:08 UTC) #5
kthelgason
On 2016/09/27 11:43:10, henrika_webrtc wrote: > Could you make an isolated change where the diff ...
4 years, 2 months ago (2016-09-27 11:54:02 UTC) #6
tkchin_webrtc
lgtm
4 years, 2 months ago (2016-09-27 13:40:01 UTC) #7
tkchin_webrtc
https://codereview.webrtc.org/2372203002/diff/20001/webrtc/examples/objc/AppRTCMobile/ios/Info.plist File webrtc/examples/objc/AppRTCMobile/ios/Info.plist (right): https://codereview.webrtc.org/2372203002/diff/20001/webrtc/examples/objc/AppRTCMobile/ios/Info.plist#newcode65 webrtc/examples/objc/AppRTCMobile/ios/Info.plist:65: <string>AppRTCDemo needs access to the camera</string> Consider not using ...
4 years, 2 months ago (2016-09-27 13:41:07 UTC) #8
kthelgason
https://codereview.webrtc.org/2372203002/diff/20001/webrtc/examples/objc/AppRTCMobile/ios/Info.plist File webrtc/examples/objc/AppRTCMobile/ios/Info.plist (right): https://codereview.webrtc.org/2372203002/diff/20001/webrtc/examples/objc/AppRTCMobile/ios/Info.plist#newcode65 webrtc/examples/objc/AppRTCMobile/ios/Info.plist:65: <string>AppRTCDemo needs access to the camera</string> On 2016/09/27 13:41:07, ...
4 years, 2 months ago (2016-09-27 13:55:33 UTC) #9
magjed_webrtc
lgtm
4 years, 2 months ago (2016-09-27 14:36:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2372203002/40001
4 years, 2 months ago (2016-09-27 14:38:02 UTC) #13
kthelgason
4 years, 2 months ago (2016-09-27 16:03:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
41514718a8cf326f4ae3d68e54ca8614d2e527a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698