Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2372113005: Replace RTCPUtility RTCPParser with TestRtcpParser (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace RTCPUtility RtcpParser with Test RtcpParser making code cleaner BUG=webrtc:5565 Committed: https://crrev.com/3dc929ea564dd2d5260b618754ffb2c716eadcb8 Cr-Commit-Position: refs/heads/master@{#14893}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -151 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/rtcp_packet_parser.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M webrtc/test/rtcp_packet_parser.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 9 chunks +52 lines, -110 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 4 chunks +20 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danilchap
4 years, 1 month ago (2016-10-31 17:20:40 UTC) #4
stefan-webrtc
lgtm nice!
4 years, 1 month ago (2016-11-02 13:31:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2372113005/20001
4 years, 1 month ago (2016-11-02 13:57:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 15:22:02 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 15:50:01 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3dc929ea564dd2d5260b618754ffb2c716eadcb8
Cr-Commit-Position: refs/heads/master@{#14893}

Powered by Google App Engine
This is Rietveld 408576698