Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2372013002: fake_network_pipe: Reduce processing interval (Closed)

Created:
4 years, 2 months ago by Irfan
Modified:
4 years, 2 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

The current default schedule delay of 30 ms prohibits scaling to high bitrates when probing. BUG=webrtc:6332 Committed: https://crrev.com/90ce01dbbea9a0dcdb4e9e77365c15a2289f28d7 Cr-Commit-Position: refs/heads/master@{#14427}

Patch Set 1 : fake_network_pipe: Reduce processing interval #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/test/fake_network_pipe.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Irfan
4 years, 2 months ago (2016-09-29 07:43:43 UTC) #6
stefan-webrtc
30 ms was way too high. lgtm
4 years, 2 months ago (2016-09-29 07:57:48 UTC) #7
philipel
lgtm
4 years, 2 months ago (2016-09-29 07:59:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2372013002/60001
4 years, 2 months ago (2016-09-29 08:34:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 2 months ago (2016-09-29 09:02:15 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 09:02:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90ce01dbbea9a0dcdb4e9e77365c15a2289f28d7
Cr-Commit-Position: refs/heads/master@{#14427}

Powered by Google App Engine
This is Rietveld 408576698