Delete webrtc::VideoFrame::CopyFrame.

Delete webrtc::VideoFrame::CopyFrame.

BUG=webrtc:5682
Committed: https://crrev.com/0e7c7ce35d9449c5bb13328d1bfb04ad32e48ccc
Cr-Commit-Position: refs/heads/master@{#14550}

[nisse-webrtc, 2016-10-06 09:38:56]

nisse@webrtc.org changed reviewers:
+ magjed@webrtc.org, tommi@webrtc.org

[nisse-webrtc, 2016-10-06 09:38:57]

This deletes the CopyFrame method (deep copy). Since VideoFrameBuffer are
usually not modified after initialization, there's little need for this
operation.

Regarding the ShallowCopy method, I wonder if it would make more sense to
replace it by a copy constructor? I think

VideoFrame frame_copy(some_frame);

is cleaner than

VideoFrame frame_copy;
frame_copy.ShallowCopy(some_frame);

In particular because I'd like to eliminate the default constructor, which
leaves the frame in a useless state with the video_frame_buffer() method
returning nullptr.

[magjed_webrtc, 2016-10-06 10:50:46]

On 2016/10/06 09:38:57, nisse-webrtc wrote:
> This deletes the CopyFrame method (deep copy). Since VideoFrameBuffer are
> usually not modified after initialization, there's little need for this
> operation.
> 
> Regarding the ShallowCopy method, I wonder if it would make more sense to
> replace it by a copy constructor? I think
> 
> VideoFrame frame_copy(some_frame);
> 
> is cleaner than
> 
> VideoFrame frame_copy;
> frame_copy.ShallowCopy(some_frame);
> 
> In particular because I'd like to eliminate the default constructor, which
> leaves the frame in a useless state with the video_frame_buffer() method
> returning nullptr.

I'm fine with removing ShallowCopy. We already have a copy constructor and use
it in a lot of places.

[magjed_webrtc, 2016-10-06 10:51:01]

This CL lgtm.

[tommi, 2016-10-06 11:11:54]

lgtm

[nisse-webrtc, 2016-10-06 11:22:10]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-10-06 11:22:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-06 12:00:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 12:00:18]

Description was changed from

==========
Delete webrtc::VideoFrame::CopyFrame.

BUG=webrtc:5682
==========

to

==========
Delete webrtc::VideoFrame::CopyFrame.

BUG=webrtc:5682

Committed: https://crrev.com/0e7c7ce35d9449c5bb13328d1bfb04ad32e48ccc
Cr-Commit-Position: refs/heads/master@{#14550}
==========

[commit-bot: I haz the power, 2016-10-06 12:00:19]

Patchset 2 (id:??) landed as
https://crrev.com/0e7c7ce35d9449c5bb13328d1bfb04ad32e48ccc
Cr-Commit-Position: refs/heads/master@{#14550}

[ivoc, 2016-10-06 13:29:09]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2397943003/ by ivoc@webrtc.org.

The reason for reverting is: This CL breaks internal dependencies..