Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2370853005: Move bitstream parser to more appropriate directory. (Closed)

Created:
4 years, 2 months ago by kthelgason
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move current bitstream parser to more appropriate directory. This CL groups together the code that has to do with parsing H264 bitstreams. This code logically belongs together, and having it in the same directory not only simplifies things from a project structure perspective, but also makes it easier to refactor out common parts incrementally. An added benefit is that this simplifies modular compilation, where for example one would like a build of WebRTC without the H264 codec-specific parts. BUG=webrtc:6338 Committed: https://crrev.com/cc6817e9ce4a5ffc73efb660cf0368afbc7d9a4f Cr-Commit-Position: refs/heads/master@{#14684}

Patch Set 1 #

Patch Set 2 : revert changes to videotoolbox encoder #

Total comments: 1

Patch Set 3 : remove unused includes #

Patch Set 4 : remove moved files from gyp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -427 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A + webrtc/common_video/h264/h264_bitstream_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/common_video/h264/h264_bitstream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/common_video/h264/h264_bitstream_parser_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/video_coding/utility/h264_bitstream_parser.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/modules/video_coding/utility/h264_bitstream_parser.cc View 1 chunk +0 lines, -293 lines 0 comments Download
D webrtc/modules/video_coding/utility/h264_bitstream_parser_unittest.cc View 1 2 3 1 chunk +0 lines, -62 lines 0 comments Download
M webrtc/modules/video_coding/utility/video_coding_utility.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
kthelgason
4 years, 2 months ago (2016-09-27 14:12:29 UTC) #2
magjed_webrtc
https://codereview.webrtc.org/2370853005/diff/20001/webrtc/common_video/h264/h264_common.h File webrtc/common_video/h264/h264_common.h (right): https://codereview.webrtc.org/2370853005/diff/20001/webrtc/common_video/h264/h264_common.h#newcode20 webrtc/common_video/h264/h264_common.h:20: #include "webrtc/common_video/h264/pps_parser.h" I don't think these includes are needed?
4 years, 2 months ago (2016-09-27 14:39:20 UTC) #4
kthelgason
On 2016/09/27 14:39:20, magjed_webrtc wrote: > https://codereview.webrtc.org/2370853005/diff/20001/webrtc/common_video/h264/h264_common.h > File webrtc/common_video/h264/h264_common.h (right): > > https://codereview.webrtc.org/2370853005/diff/20001/webrtc/common_video/h264/h264_common.h#newcode20 > ...
4 years, 2 months ago (2016-09-28 08:19:12 UTC) #5
magjed_webrtc
lgtm
4 years, 2 months ago (2016-09-28 14:03:24 UTC) #6
kthelgason
Added mflodman@ as a reviewer.
4 years, 2 months ago (2016-10-03 09:15:52 UTC) #8
kthelgason
- mflodman + holmer
4 years, 2 months ago (2016-10-18 08:22:38 UTC) #12
stefan-webrtc
lgtm
4 years, 2 months ago (2016-10-18 18:26:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2370853005/60001
4 years, 2 months ago (2016-10-19 12:07:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
4 years, 2 months ago (2016-10-19 14:07:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2370853005/60001
4 years, 2 months ago (2016-10-19 14:48:30 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-19 16:31:17 UTC) #24
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/cc6817e9ce4a5ffc73efb660cf0368afbc7d9a4f Cr-Commit-Position: refs/heads/master@{#14684}
4 years, 2 months ago (2016-10-19 16:54:10 UTC) #26
kthelgason
4 years, 2 months ago (2016-10-19 17:34:24 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/2430353004/ by kthelgason@webrtc.org.

The reason for reverting is: Breaks internal project
.

Powered by Google App Engine
This is Rietveld 408576698