Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2370723002: Delete unused file sessionid.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 1 month ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused file sessionid.h. BUG=None. Committed: https://crrev.com/de2920cb46e6ec75838679350ef2eb67077da4db Cr-Commit-Position: refs/heads/master@{#14387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M webrtc/p2p/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/p2p/base/sessionid.h View 1 chunk +0 lines, -20 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
nisse-webrtc
PTAL. Should I file some bug for deleting cruft like this? I have a short ...
4 years, 2 months ago (2016-09-26 09:14:03 UTC) #2
perkj_webrtc
lgtm
4 years, 2 months ago (2016-09-26 09:35:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2370723002/1
4 years, 2 months ago (2016-09-26 09:44:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 2 months ago (2016-09-26 11:44:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2370723002/1
4 years, 2 months ago (2016-09-27 06:20:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 06:28:49 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 06:28:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de2920cb46e6ec75838679350ef2eb67077da4db
Cr-Commit-Position: refs/heads/master@{#14387}

Powered by Google App Engine
This is Rietveld 408576698