webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc - Issue 2370313002: Reland of Unify rtcp packet setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)

Patch Set: Fix breaking mistype Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc

index 44c82d67a937b2cb1daed05c9a596b5ee9e25236..d12889d7b9cfbec5a9c5672c047caad92384bc9e 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc

@@ -51,8 +51,8 @@ TEST(RtcpPacketVoipMetricTest, Create) {

metric.JBmax = 0x6667;

metric.JBabsMax = 0x7778;

VoipMetric metric_block;

- metric_block.To(kRemoteSsrc);

- metric_block.WithVoipMetric(metric);

+ metric_block.SetMediaSsrc(kRemoteSsrc);

+ metric_block.SetVoipMetric(metric);

metric_block.Create(buffer);

EXPECT_EQ(0, memcmp(buffer, kBlock, kBlockSizeBytes));