Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)
Patch Set: Fix breaking mistype Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
index a4f0f6bbdc56a50a25da45e955b9a1bde5cf589a..9008aa0939a56f3f3baa8db8ba1e0a683b2c9f2b 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
@@ -304,8 +304,8 @@ int64_t TransportFeedback::Unwrap(uint16_t sequence_number) {
return last_seq_ + delta;
}
-void TransportFeedback::WithBase(uint16_t base_sequence,
- int64_t ref_timestamp_us) {
+void TransportFeedback::SetBase(uint16_t base_sequence,
+ int64_t ref_timestamp_us) {
RTC_DCHECK_EQ(-1, base_seq_);
RTC_DCHECK_NE(-1, ref_timestamp_us);
base_seq_ = base_sequence;
@@ -318,12 +318,12 @@ void TransportFeedback::WithBase(uint16_t base_sequence,
last_timestamp_ = base_time_ * kBaseScaleFactor;
}
-void TransportFeedback::WithFeedbackSequenceNumber(uint8_t feedback_sequence) {
+void TransportFeedback::SetFeedbackSequenceNumber(uint8_t feedback_sequence) {
feedback_seq_ = feedback_sequence;
}
-bool TransportFeedback::WithReceivedPacket(uint16_t sequence_number,
- int64_t timestamp) {
+bool TransportFeedback::AddReceivedPacket(uint16_t sequence_number,
+ int64_t timestamp) {
RTC_DCHECK_NE(-1, base_seq_);
int64_t seq = Unwrap(sequence_number);
if (seq != base_seq_ && seq <= last_seq_)

Powered by Google App Engine
This is Rietveld 408576698