Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)
Patch Set: Fix breaking mistype Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
index a544017f1495ba4c6f0c934a4370bb01acaf6dce..91a66b7e8a53c2b5781d129b25550dd0bbe62fee 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h
@@ -32,18 +32,18 @@ class SenderReport : public RtcpPacket {
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
- void From(uint32_t ssrc) { sender_ssrc_ = ssrc; }
- void WithNtp(NtpTime ntp) { ntp_ = ntp; }
- void WithRtpTimestamp(uint32_t rtp_timestamp) {
+ void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; }
+ void SetNtp(NtpTime ntp) { ntp_ = ntp; }
+ void SetRtpTimestamp(uint32_t rtp_timestamp) {
rtp_timestamp_ = rtp_timestamp;
}
- void WithPacketCount(uint32_t packet_count) {
+ void SetPacketCount(uint32_t packet_count) {
sender_packet_count_ = packet_count;
}
- void WithOctetCount(uint32_t octet_count) {
+ void SetOctetCount(uint32_t octet_count) {
sender_octet_count_ = octet_count;
}
- bool WithReportBlock(const ReportBlock& block);
+ bool AddReportBlock(const ReportBlock& block);
void ClearReportBlocks() { report_blocks_.clear(); }
uint32_t sender_ssrc() const { return sender_ssrc_; }

Powered by Google App Engine
This is Rietveld 408576698