webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h - Issue 2370313002: Reland of Unify rtcp packet setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)

Patch Set: Fix breaking mistype Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h

index de1cf760bbaa64b52e57636713a66879af1412ca..b34e4a02d6f12fda9675d7ef27f1c24278d1bcba 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h

@@ -27,8 +27,8 @@ class Rtpfb : public RtcpPacket {

Rtpfb() : sender_ssrc_(0), media_ssrc_(0) {}

~Rtpfb() override {}

- void From(uint32_t ssrc) { sender_ssrc_ = ssrc; }

- void To(uint32_t ssrc) { media_ssrc_ = ssrc; }

+ void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; }

+ void SetMediaSsrc(uint32_t ssrc) { media_ssrc_ = ssrc; }

uint32_t sender_ssrc() const { return sender_ssrc_; }

uint32_t media_ssrc() const { return media_ssrc_; }