Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block_unittest.cc

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)
Patch Set: Fix breaking mistype Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block_unittest.cc
index 85bbb404a4401abcaf91aff92b0979ff5961a42d..957a08ffbf9fff248aa7e65fc0e36f423e82eba7 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block_unittest.cc
@@ -52,13 +52,13 @@ TEST(RtcpPacketReportBlockTest, ParseAnyData) {
TEST(RtcpPacketReportBlockTest, ParseMatchCreate) {
ReportBlock rb;
- rb.To(kRemoteSsrc);
- rb.WithFractionLost(kFractionLost);
- rb.WithCumulativeLost(kCumulativeLost);
- rb.WithExtHighestSeqNum(kExtHighestSeqNum);
- rb.WithJitter(kJitter);
- rb.WithLastSr(kLastSr);
- rb.WithDelayLastSr(kDelayLastSr);
+ rb.SetMediaSsrc(kRemoteSsrc);
+ rb.SetFractionLost(kFractionLost);
+ rb.SetCumulativeLost(kCumulativeLost);
+ rb.SetExtHighestSeqNum(kExtHighestSeqNum);
+ rb.SetJitter(kJitter);
+ rb.SetLastSr(kLastSr);
+ rb.SetDelayLastSr(kDelayLastSr);
uint8_t buffer[kBufferLength];
rb.Create(buffer);
@@ -78,8 +78,8 @@ TEST(RtcpPacketReportBlockTest, ParseMatchCreate) {
TEST(RtcpPacketReportBlockTest, ValidateCumulativeLost) {
const uint32_t kMaxCumulativeLost = 0xffffff;
ReportBlock rb;
- EXPECT_FALSE(rb.WithCumulativeLost(kMaxCumulativeLost + 1));
- EXPECT_TRUE(rb.WithCumulativeLost(kMaxCumulativeLost));
+ EXPECT_FALSE(rb.SetCumulativeLost(kMaxCumulativeLost + 1));
+ EXPECT_TRUE(rb.SetCumulativeLost(kMaxCumulativeLost));
}
} // namespace
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698