Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)
Patch Set: Fix breaking mistype Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h
index 83b3ba954b6f8652ab2cd230d331b024d8672177..e346200a8e1b3093c08a97b390370dfbd8bd6e2d 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h
@@ -30,7 +30,7 @@ class Nack : public Rtpfb {
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
- void WithList(const uint16_t* nack_list, size_t length);
+ void SetPacketIds(const uint16_t* nack_list, size_t length);
const std::vector<uint16_t>& packet_ids() const { return packet_ids_; }
protected:
@@ -48,7 +48,7 @@ class Nack : public Rtpfb {
uint16_t bitmask;
};
- void Pack(); // Fills packed_ using packed_ids_. (used in WithList).
+ void Pack(); // Fills packed_ using packed_ids_. (used in SetPacketIds).
void Unpack(); // Fills packet_ids_ using packed_. (used in Parse).
std::vector<PackedNack> packed_;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698