Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)
Patch Set: Fix breaking mistype Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h
index b15d4165835bbc901aea29a5d46770d0a2fbbdcc..7b6c54452f8972df55631459761fc87a46384984 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h
@@ -34,12 +34,12 @@ class ExtendedReports : public RtcpPacket {
// Parse assumes header is already parsed and validated.
bool Parse(const CommonHeader& packet);
- void From(uint32_t ssrc) { sender_ssrc_ = ssrc; }
+ void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; }
// Max 50 items of each of {Rrtr, Dlrr, VoipMetric} allowed per Xr.
- bool WithRrtr(const Rrtr& rrtr);
- bool WithDlrr(const Dlrr& dlrr);
- bool WithVoipMetric(const VoipMetric& voip_metric);
+ bool AddRrtr(const Rrtr& rrtr);
+ bool AddDlrr(const Dlrr& dlrr);
+ bool AddVoipMetric(const VoipMetric& voip_metric);
uint32_t sender_ssrc() const { return sender_ssrc_; }
const std::vector<Rrtr>& rrtrs() const { return rrtr_blocks_; }

Powered by Google App Engine
This is Rietveld 408576698