Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)
Patch Set: Fix breaking mistype Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc
index 205fdbb092f415932e59b84a1b1c3f32d78c3689..a2d37a4dfc35632f7369bdba6dee0beeadbec3e1 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc
@@ -51,12 +51,12 @@ bool App::Parse(const CommonHeader& packet) {
return true;
}
-void App::WithSubType(uint8_t subtype) {
+void App::SetSubType(uint8_t subtype) {
RTC_DCHECK_LE(subtype, 0x1f);
sub_type_ = subtype;
}
-void App::WithData(const uint8_t* data, size_t data_length) {
+void App::SetData(const uint8_t* data, size_t data_length) {
RTC_DCHECK(data);
RTC_DCHECK_EQ(data_length % 4, 0u) << "Data must be 32 bits aligned.";
RTC_DCHECK_LE(data_length, kMaxDataSize) << "App data size " << data_length
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698