Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc

Issue 2370313002: Reland of Unify rtcp packet setters (Closed)
Patch Set: Fix breaking mistype Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // Write report blocks. 98 // Write report blocks.
99 for (const ReportBlock& block : report_blocks_) { 99 for (const ReportBlock& block : report_blocks_) {
100 block.Create(packet + *index); 100 block.Create(packet + *index);
101 *index += ReportBlock::kLength; 101 *index += ReportBlock::kLength;
102 } 102 }
103 // Ensure bytes written match expected. 103 // Ensure bytes written match expected.
104 RTC_DCHECK_EQ(*index, index_end); 104 RTC_DCHECK_EQ(*index, index_end);
105 return true; 105 return true;
106 } 106 }
107 107
108 bool SenderReport::WithReportBlock(const ReportBlock& block) { 108 bool SenderReport::AddReportBlock(const ReportBlock& block) {
109 if (report_blocks_.size() >= kMaxNumberOfReportBlocks) { 109 if (report_blocks_.size() >= kMaxNumberOfReportBlocks) {
110 LOG(LS_WARNING) << "Max report blocks reached."; 110 LOG(LS_WARNING) << "Max report blocks reached.";
111 return false; 111 return false;
112 } 112 }
113 report_blocks_.push_back(block); 113 report_blocks_.push_back(block);
114 return true; 114 return true;
115 } 115 }
116 116
117 } // namespace rtcp 117 } // namespace rtcp
118 } // namespace webrtc 118 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698