Reland of Unify rtcp packet setters

webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h"
 
+#include <utility>
+
 #include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h"
 
 namespace webrtc {
 namespace rtcp {
 
 // Bye packet (BYE) (RFC 3550).
 //
@@ skipping 79 matching lines @@
     RTC_DCHECK_LE(bytes_to_pad, 3u);
     if (bytes_to_pad > 0) {
       memset(&packet[*index], 0, bytes_to_pad);
       *index += bytes_to_pad;
     }
   }
   RTC_DCHECK_EQ(index_end, *index);
   return true;
 }
 
-bool Bye::WithCsrc(uint32_t csrc) {
-  if (csrcs_.size() >= kMaxNumberOfCsrcs) {
-    LOG(LS_WARNING) << "Max CSRC size reached.";
+bool Bye::SetCsrcs(std::vector<uint32_t> csrcs) {
+  if (csrcs.size() > kMaxNumberOfCsrcs) {
+    LOG(LS_WARNING) << "Too many CSRCs for Bye packet.";
     return false;
   }
-  csrcs_.push_back(csrc);
+  csrcs_ = std::move(csrcs);
   return true;
 }
 
-void Bye::WithReason(const std::string& reason) {
+void Bye::SetReason(std::string reason) {
   RTC_DCHECK_LE(reason.size(), 0xffu);
-  reason_ = reason;
+  reason_ = std::move(reason);
 }
 
 size_t Bye::BlockLength() const {
   size_t src_count = (1 + csrcs_.size());
   size_t reason_size_in_32bits = reason_.empty() ? 0 : (reason_.size() / 4 + 1);
   return kHeaderLength + 4 * (src_count + reason_size_in_32bits);
 }
 
 }  // namespace rtcp
 }  // namespace webrtc