Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2369893002: Enable //build/config/clang:extra_warnings for rtc_media (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable //build/config/clang:extra_warnings for rtc_media The code compiles fine with this config removed. BUG=webrtc:6323 NOTRY=True NOTREECHECKS=True Committed: https://crrev.com/660312b0c6add8e14b2a1a908f24bf260ae6453a Cr-Commit-Position: refs/heads/master@{#14381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kjellander_webrtc
4 years, 2 months ago (2016-09-26 11:33:50 UTC) #3
ehmaldonado_webrtc
On 2016/09/26 11:33:50, kjellander_webrtc wrote: LGTM
4 years, 2 months ago (2016-09-26 11:35:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2369893002/1
4 years, 2 months ago (2016-09-26 13:04:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 13:11:58 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 13:12:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/660312b0c6add8e14b2a1a908f24bf260ae6453a
Cr-Commit-Position: refs/heads/master@{#14381}

Powered by Google App Engine
This is Rietveld 408576698