|
|
Descriptionr14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the
flag. This change moves it to WARNING_CFLAGS, and makes it work for both
iOS and mac.
BUG=webrtc:6396
NOTRY=True
NOPRESUBMIT=True
NOTREECHECKS=True
Committed: https://crrev.com/20684110fdbde0818579eea472ee376b31249fde
Cr-Commit-Position: refs/heads/master@{#14378}
Patch Set 1 #Patch Set 2 : Ignores SecRandomCopyBytes() warning for GYP build. #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== Ignores SecRandomCopyBytes() warning for GYP build. BUG=webrtc:6396 ========== to ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 ==========
Description was changed from ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 ========== to ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 ==========
Description was changed from ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 ========== to ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 ==========
jianjun.zhu@intel.com changed reviewers: + henrika@webrtc.org
PTAL
Description was changed from ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 ========== to ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 ==========
henrika@webrtc.org changed reviewers: + kjellander@webrtc.org
kjellander@: any input here?
Description was changed from ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 ========== to ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 NOTRY=True ==========
Description was changed from ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 NOTRY=True ========== to ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 NOTRY=True NOPRESUBMIT=True NOTREECHECKS=True ==========
LGTM from my side
lgtm we didn't notice the error since we almost don't utilize GYP any more (it's deprecated and mostly don't work anyway).
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 NOTRY=True NOPRESUBMIT=True NOTREECHECKS=True ========== to ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 NOTRY=True NOPRESUBMIT=True NOTREECHECKS=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 NOTRY=True NOPRESUBMIT=True NOTREECHECKS=True ========== to ========== r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 NOTRY=True NOPRESUBMIT=True NOTREECHECKS=True Committed: https://crrev.com/20684110fdbde0818579eea472ee376b31249fde Cr-Commit-Position: refs/heads/master@{#14378} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/20684110fdbde0818579eea472ee376b31249fde Cr-Commit-Position: refs/heads/master@{#14378} |