Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2369803002: Ignores SecRandomCopyBytes() warning for GYP build. (Closed)

Created:
4 years, 2 months ago by jianjunz
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

r14326 added '-Wno-unused-result' to 'WARNING_CFLAGS!' which removes the flag. This change moves it to WARNING_CFLAGS, and makes it work for both iOS and mac. BUG=webrtc:6396 NOTRY=True NOPRESUBMIT=True NOTREECHECKS=True Committed: https://crrev.com/20684110fdbde0818579eea472ee376b31249fde Cr-Commit-Position: refs/heads/master@{#14378}

Patch Set 1 #

Patch Set 2 : Ignores SecRandomCopyBytes() warning for GYP build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M webrtc/webrtc_examples.gyp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
jianjunz
PTAL
4 years, 2 months ago (2016-09-26 01:59:45 UTC) #5
henrika_webrtc
4 years, 2 months ago (2016-09-26 09:36:05 UTC) #8
henrika_webrtc
kjellander@: any input here?
4 years, 2 months ago (2016-09-26 09:36:36 UTC) #9
henrika_webrtc
LGTM from my side
4 years, 2 months ago (2016-09-26 09:40:15 UTC) #12
kjellander_webrtc
lgtm we didn't notice the error since we almost don't utilize GYP any more (it's ...
4 years, 2 months ago (2016-09-26 09:41:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2369803002/20001
4 years, 2 months ago (2016-09-26 09:41:30 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 09:41:41 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 09:41:47 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20684110fdbde0818579eea472ee376b31249fde
Cr-Commit-Position: refs/heads/master@{#14378}

Powered by Google App Engine
This is Rietveld 408576698