Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2368983002: Replace RtcpReceiveTimeInfo with rtcp::ReceiveTimeInfo (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace RtcpReceiveTimeInfo with rtcp::ReceiveTimeInfo structs are exactly the same but last one follow naming style. BUG=webrtc:5565 Committed: https://crrev.com/798896a4aa96e3e954ad3b6507f57dbfe0b74dcf Cr-Commit-Position: refs/heads/master@{#14415}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -48 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 4 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 5 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danilchap
4 years, 2 months ago (2016-09-27 17:14:52 UTC) #3
philipel
lgtm
4 years, 2 months ago (2016-09-28 08:34:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368983002/20001
4 years, 2 months ago (2016-09-28 08:43:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 09:54:31 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 09:54:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/798896a4aa96e3e954ad3b6507f57dbfe0b74dcf
Cr-Commit-Position: refs/heads/master@{#14415}

Powered by Google App Engine
This is Rietveld 408576698