Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2368543002: Remove unnecessary jsoncpp includes. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
Reviewers:
charujain
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary jsoncpp includes. These are already added in third_party/jsoncpp/BUILD.gn so they shouldn't be needed. BUG=webrtc:6412 NOTRY=True NOTREECHECKS=True Committed: https://crrev.com/390112807513c3385dd8ece32791ad8dccd3ab94 Cr-Commit-Position: refs/heads/master@{#14379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
I've verified downstream that this doesn't break any internal project.
4 years, 2 months ago (2016-09-26 09:27:35 UTC) #2
charujain
lgtm
4 years, 2 months ago (2016-09-26 09:34:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368543002/1
4 years, 2 months ago (2016-09-26 09:48:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 09:52:36 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 09:52:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/390112807513c3385dd8ece32791ad8dccd3ab94
Cr-Commit-Position: refs/heads/master@{#14379}

Powered by Google App Engine
This is Rietveld 408576698