Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2368203002: Delete unused class cricket::MediaSinkInterface, and mediasink.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused class cricket::MediaSinkInterface, and mediasink.h. Also update gyp dependency from rtc_base to rtc_base_approved. BUG=None. Committed: https://crrev.com/7ba305111abff85d8a2996d2ed46f64eb65b3c19 Cr-Commit-Position: refs/heads/master@{#14497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -34 lines) Patch
M webrtc/pc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/pc/mediasink.h View 1 chunk +0 lines, -31 lines 0 comments Download
M webrtc/pc/pc.gyp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
nisse-webrtc
Another apparently dead file.
4 years, 2 months ago (2016-09-26 09:29:53 UTC) #3
perkj_webrtc
lgtm I have never seen this file before though.
4 years, 2 months ago (2016-09-26 09:35:01 UTC) #4
nisse-webrtc
Peter, do you know what this code was used for?
4 years, 2 months ago (2016-09-26 09:45:21 UTC) #6
pthatcher1
lgtm Looks like someone tried to make a generic media transport interface. It must not ...
4 years, 2 months ago (2016-10-03 22:44:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368203002/1
4 years, 2 months ago (2016-10-04 06:58:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-04 08:58:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368203002/1
4 years, 2 months ago (2016-10-04 12:25:27 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 12:33:51 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 12:34:01 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ba305111abff85d8a2996d2ed46f64eb65b3c19
Cr-Commit-Position: refs/heads/master@{#14497}

Powered by Google App Engine
This is Rietveld 408576698