Move class RTCPHelp::RTCPPacketInformation into RTCPReceiver

Move class RTCPHelp::RTCPPacketInformation into RTCPReceiver
Use it by pointer instead of by reference.
Renamed PacketInformation members to follow style,
Unused members removed.

BUG=webrtc:5565
Committed: https://crrev.com/92ea601e90c3fc12624ce35bb62ceaca8bc07f1b
Cr-Commit-Position: refs/heads/master@{#14375}

[danilchap, 2016-09-22 11:24:39]

danilchap@webrtc.org changed reviewers:
+ philipel@webrtc.org

[philipel, 2016-09-23 11:33:01]

https://codereview.webrtc.org/2366563002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2366563002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:70: uint32_t
rtcpPacketTypeFlags;  // RTCPPacketTypeFlags bit field
Change all camelCase to use underscore as separator instead in this class.

https://codereview.webrtc.org/2366563002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:109:
RTCPReceiver::PacketInformation::~PacketInformation() {}
Remove dtor

[danilchap, 2016-09-23 12:12:21]

Description was changed from

==========
Move class RTCPHelp::RTCPPacketInformation into RTCPReceiver
Use it by pointer instead of by reference.

BUG=webrtc:5565
==========

to

==========
Move class RTCPHelp::RTCPPacketInformation into RTCPReceiver
Use it by pointer instead of by reference.
Renamed PacketInformation members to follow style,
Unused members removed.

BUG=webrtc:5565
==========

[danilchap, 2016-09-23 12:35:55]

https://codereview.webrtc.org/2366563002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2366563002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:70: uint32_t
rtcpPacketTypeFlags;  // RTCPPacketTypeFlags bit field
On 2016/09/23 11:33:01, philipel wrote:
> Change all camelCase to use underscore as separator instead in this class.

Planned to do PacketInformation cleanup in follow-up CL, but if you do not mind
to review it here, here it is.
If you prefer cleanup moved to follow-up (there is more cleanup than just
renaming), I do not mind to revert this patchset.

https://codereview.webrtc.org/2366563002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:109:
RTCPReceiver::PacketInformation::~PacketInformation() {}
On 2016/09/23 11:33:01, philipel wrote:
> Remove dtor

Done.

[philipel, 2016-09-23 13:27:39]

lgtm with nit

https://codereview.webrtc.org/2366563002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2366563002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:64: uint32_t packet_type_flags =
0;  // RTCPPacketTypeFlags bit field.
Are the member variables divided into logical groups? Is |packet_type_flags|
"close" to |remote_ssrc| but not the others? If not I think you should remove
the empty lines in this struct.

[danilchap, 2016-09-23 13:35:32]

https://codereview.webrtc.org/2366563002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2366563002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:64: uint32_t packet_type_flags =
0;  // RTCPPacketTypeFlags bit field.
On 2016/09/23 13:27:39, philipel wrote:
> Are the member variables divided into logical groups? Is |packet_type_flags|
> "close" to |remote_ssrc| but not the others? If not I think you should remove
> the empty lines in this struct.

Good point, thank you.
Removed all empty lines, but then added one to separate packet_type_flags.

[danilchap, 2016-09-23 16:11:49]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-09-23 16:11:50]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2366563002/#ps80001 (title:
"nit")

[commit-bot: I haz the power, 2016-09-23 16:11:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-23 17:36:06]

Description was changed from

==========
Move class RTCPHelp::RTCPPacketInformation into RTCPReceiver
Use it by pointer instead of by reference.
Renamed PacketInformation members to follow style,
Unused members removed.

BUG=webrtc:5565
==========

to

==========
Move class RTCPHelp::RTCPPacketInformation into RTCPReceiver
Use it by pointer instead of by reference.
Renamed PacketInformation members to follow style,
Unused members removed.

BUG=webrtc:5565
==========

[commit-bot: I haz the power, 2016-09-23 17:36:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-23 17:36:19]

Description was changed from

==========
Move class RTCPHelp::RTCPPacketInformation into RTCPReceiver
Use it by pointer instead of by reference.
Renamed PacketInformation members to follow style,
Unused members removed.

BUG=webrtc:5565
==========

to

==========
Move class RTCPHelp::RTCPPacketInformation into RTCPReceiver
Use it by pointer instead of by reference.
Renamed PacketInformation members to follow style,
Unused members removed.

BUG=webrtc:5565

Committed: https://crrev.com/92ea601e90c3fc12624ce35bb62ceaca8bc07f1b
Cr-Commit-Position: refs/heads/master@{#14375}
==========

[commit-bot: I haz the power, 2016-09-23 17:36:20]

Patchset 5 (id:??) landed as
https://crrev.com/92ea601e90c3fc12624ce35bb62ceaca8bc07f1b
Cr-Commit-Position: refs/heads/master@{#14375}