iOS: Always build H264 HW encoder/decoder

iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
NOTRY=TRUE

Committed: https://crrev.com/44428a8aa644d8e030dae9643e05d6025d4cdd6c
Cr-Commit-Position: refs/heads/master@{#14372}

[magjed_webrtc, 2016-09-22 08:05:27]

Description was changed from

==========
iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
==========

to

==========
iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
==========

[magjed_webrtc, 2016-09-22 08:05:27]

magjed@webrtc.org changed reviewers:
+ kthelgason@webrtc.org, tkchin@webrtc.org

[magjed_webrtc, 2016-09-22 08:06:11]

Description was changed from

==========
iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
==========

to

==========
iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
NOTRY=TRUE
==========

[magjed_webrtc, 2016-09-22 08:06:21]

Please take a look.

[kthelgason, 2016-09-22 13:20:18]

On 2016/09/22 08:06:21, magjed_webrtc wrote:
> Please take a look.

This seems like a good thing to me. Why not go all the way and remove the
#define as well, and get rid of some #ifdefs?

[magjed_webrtc, 2016-09-22 15:12:56]

On 2016/09/22 13:20:18, kthelgason wrote:
> On 2016/09/22 08:06:21, magjed_webrtc wrote:
> > Please take a look.
> 
> This seems like a good thing to me. Why not go all the way and remove the
> #define as well, and get rid of some #ifdefs?

Because I'm stupid? Done.

[tkchin_webrtc, 2016-09-22 17:01:13]

lgtm

https://codereview.webrtc.org/2366443003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/h264/h264_objc.mm (right):

https://codereview.webrtc.org/2366443003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/h264/h264_objc.mm:26: // TODO(tkchin):
Support OS/X once we stop mixing libstdc++ and libc++ on
just fyi with new GN stuff the whole libc++ / libstdc++ issue has been resolved,
and this should build for OS/X correctly now.

[magjed_webrtc, 2016-09-23 07:38:43]

https://codereview.webrtc.org/2366443003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/h264/h264_objc.mm (right):

https://codereview.webrtc.org/2366443003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/h264/h264_objc.mm:26: // TODO(tkchin):
Support OS/X once we stop mixing libstdc++ and libc++ on
On 2016/09/22 17:01:12, tkchin_webrtc wrote:
> just fyi with new GN stuff the whole libc++ / libstdc++ issue has been
resolved,
> and this should build for OS/X correctly now.

Cool. Kari - will this help http://crbug/webrtc/6317?

[kthelgason, 2016-09-23 13:11:16]

On 2016/09/23 07:38:43, magjed_webrtc wrote:
> Cool. Kari - will this help http://crbug/webrtc/6317
Unfortunately, I don't think so. But this CL LGTM!

[magjed_webrtc, 2016-09-23 13:53:13]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-09-23 13:53:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-23 14:01:39]

Description was changed from

==========
iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
NOTRY=TRUE
==========

to

==========
iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
NOTRY=TRUE
==========

[commit-bot: I haz the power, 2016-09-23 14:01:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 14:01:47]

Description was changed from

==========
iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
NOTRY=TRUE
==========

to

==========
iOS: Always build H264 HW encoder/decoder

This CL removes the use_objc_h264 flag. This means that the VideoToolbox
H264 encoder and decoder will always be built.

BUG=webrtc:4081
NOTRY=TRUE

Committed: https://crrev.com/44428a8aa644d8e030dae9643e05d6025d4cdd6c
Cr-Commit-Position: refs/heads/master@{#14372}
==========

[commit-bot: I haz the power, 2016-09-23 14:01:49]

Patchset 2 (id:??) landed as
https://crrev.com/44428a8aa644d8e030dae9643e05d6025d4cdd6c
Cr-Commit-Position: refs/heads/master@{#14372}