Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2366383002: Enables possibility to select full-duplex OpenSL ES audio in AppRTCDemo (Closed)

Created:
4 years, 2 months ago by henrika_webrtc
Modified:
4 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

THis CL enables possibility to select full-duplex OpenSL ES audio in AppRTCDemo, i.e., it adds support for OpenSL ES for input as well. The user must explicitly select this new mode in the debug UI hence it is not the default selection. There is no separate UI for input and output; instead both are enabled/disabled by the same switch. BUG=webrtc:5925 R=tommi@webrtc.org Committed: https://crrev.com/0a52c7003da6434019cfe6806311104de57f8c7e Cr-Commit-Position: refs/heads/master@{#14390}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
henrika_webrtc
PTAL Tommi. Should be the last missing part ;-)
4 years, 2 months ago (2016-09-26 14:29:57 UTC) #5
tommi
lgtm
4 years, 2 months ago (2016-09-26 14:31:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2366383002/1
4 years, 2 months ago (2016-09-26 15:21:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 2 months ago (2016-09-26 17:21:30 UTC) #12
henrika_webrtc
4 years, 2 months ago (2016-09-27 07:35:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0a52c7003da6434019cfe6806311104de57f8c7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698