Moved Gn target rtc_event_log to one directory above

Moved Gn target rtc_event_log to one directory above.

This is done to ensure GN targets are placed in the same directory as of the source files.

BUG=webrtc:6412
NOTRY=True

Committed: https://crrev.com/89a3a1a363144ff1b26724a05656216967601527
Cr-Commit-Position: refs/heads/master@{#14411}

[charujain, 2016-09-27 07:55:11]

Description was changed from

==========
format warnings fixed


Moving gn target rtc_event_log to one directory above


BUG=
==========

to

==========
Moved Gn target rtc_event_log to one directory above. 

This is done to ensure GN targets are placed in the same directory as of the
source files. 

BUG=31106681
==========

[charujain, 2016-09-27 07:55:11]

charujain@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[charujain, 2016-09-27 08:00:47]

Description was changed from

==========
Moved Gn target rtc_event_log to one directory above. 

This is done to ensure GN targets are placed in the same directory as of the
source files. 

BUG=31106681
==========

to

==========
Moved Gn target rtc_event_log to one directory above. 

This is done to ensure GN targets are placed in the same directory as of the
source files. 

BUG=31106681
NOTRY=True
==========

[kjellander_webrtc, 2016-09-27 08:20:38]

Description was changed from

==========
Moved Gn target rtc_event_log to one directory above. 

This is done to ensure GN targets are placed in the same directory as of the
source files. 

BUG=31106681
NOTRY=True
==========

to

==========
Moved Gn target rtc_event_log to one directory above. 

This is done to ensure GN targets are placed in the same directory as of the
source files. 

BUG=webrtc:6412
NOTRY=True
==========

[kjellander_webrtc, 2016-09-27 08:20:38]

kjellander@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[kjellander_webrtc, 2016-09-27 08:21:37]

kjellander@webrtc.org changed reviewers:
+ terelius@webrtc.org
- solenberg@webrtc.org

[kjellander_webrtc, 2016-09-27 08:22:06]

lgtm, but please run compile trybots first.

+terelius@ to notify somebody that have been working on this target.

[kjellander_webrtc, 2016-09-27 08:23:09]

On 2016/09/27 08:22:06, kjellander_webrtc wrote:
> lgtm, but please run compile trybots first.
> 
> +terelius@ to notify somebody that have been working on this target.

PS. I changed to BUG=webrtc:6412 in the description. DS.

[terelius, 2016-09-27 08:32:13]

terelius@webrtc.org changed reviewers:
+ skvlad@webrtc.org

[terelius, 2016-09-27 08:32:14]

+skvlad who has talked about moving the event log to base/

Please hold off on landing this until we know whether Vladimir already started
his work.

[kjellander_webrtc, 2016-09-27 10:31:20]

On 2016/09/27 08:32:14, terelius wrote:
> +skvlad who has talked about moving the event log to base/
> 
> Please hold off on landing this until we know whether Vladimir already started
> his work.

I think he has (https://codereview.webrtc.org/2353033005/) but I don't see why
this would be problematic. It's just moving the GN target to a new location so
either way it will be a non-conflicting rebase with his CL.
I suggest to ahead and land this since it's important to unblock Charu's work.

[terelius, 2016-09-27 11:46:01]

On 2016/09/27 10:31:20, kjellander_webrtc wrote:
> On 2016/09/27 08:32:14, terelius wrote:
> > +skvlad who has talked about moving the event log to base/
> > 
> > Please hold off on landing this until we know whether Vladimir already
started
> > his work.
> 
> I think he has (https://codereview.webrtc.org/2353033005/) but I don't see why
> this would be problematic. It's just moving the GN target to a new location so
> either way it will be a non-conflicting rebase with his CL.
> I suggest to ahead and land this since it's important to unblock Charu's work.

That's a different CL. I'm talking about moving the event log sources from call/
to base/ which would presumably mean updating the exact same build targets that
Charu is updating here. The idea is to have the log in base/ in order to be able
to use it everywhere without adding special exceptions to the checkdeps rules
every time.

If this CL blocks urgent work, I suppose you should just land it anyway though.

[skvlad, 2016-09-27 18:16:46]

On 2016/09/27 11:46:01, terelius wrote:
> On 2016/09/27 10:31:20, kjellander_webrtc wrote:
> > On 2016/09/27 08:32:14, terelius wrote:
> > > +skvlad who has talked about moving the event log to base/
> > > 
> > > Please hold off on landing this until we know whether Vladimir already
> started
> > > his work.
> > 
> > I think he has (https://codereview.webrtc.org/2353033005/) but I don't see
why
> > this would be problematic. It's just moving the GN target to a new location
so
> > either way it will be a non-conflicting rebase with his CL.
> > I suggest to ahead and land this since it's important to unblock Charu's
work.
> 
> That's a different CL. I'm talking about moving the event log sources from
call/
> to base/ which would presumably mean updating the exact same build targets
that
> Charu is updating here. The idea is to have the log in base/ in order to be
able
> to use it everywhere without adding special exceptions to the checkdeps rules
> every time.
> 
> If this CL blocks urgent work, I suppose you should just land it anyway
though.

Feel free to land it, the CL to move RtcEventLog to base/ needs extra work as I
need to do something about the RTP parser dependencies.

[charujain, 2016-09-28 07:40:38]

The CQ bit was checked by charujain@webrtc.org

[commit-bot: I haz the power, 2016-09-28 07:40:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-28 07:48:59]

Description was changed from

==========
Moved Gn target rtc_event_log to one directory above. 

This is done to ensure GN targets are placed in the same directory as of the
source files. 

BUG=webrtc:6412
NOTRY=True
==========

to

==========
Moved Gn target rtc_event_log to one directory above. 

This is done to ensure GN targets are placed in the same directory as of the
source files. 

BUG=webrtc:6412
NOTRY=True
==========

[commit-bot: I haz the power, 2016-09-28 07:49:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-28 07:49:10]

Description was changed from

==========
Moved Gn target rtc_event_log to one directory above. 

This is done to ensure GN targets are placed in the same directory as of the
source files. 

BUG=webrtc:6412
NOTRY=True
==========

to

==========
Moved Gn target rtc_event_log to one directory above.

This is done to ensure GN targets are placed in the same directory as of the
source files.

BUG=webrtc:6412
NOTRY=True

Committed: https://crrev.com/89a3a1a363144ff1b26724a05656216967601527
Cr-Commit-Position: refs/heads/master@{#14411}
==========

[commit-bot: I haz the power, 2016-09-28 07:49:11]

Patchset 1 (id:??) landed as
https://crrev.com/89a3a1a363144ff1b26724a05656216967601527
Cr-Commit-Position: refs/heads/master@{#14411}