Add autothread to pseudo-tcp fuzzer.

webrtc/test/fuzzers/pseudotcp_parser_fuzzer.cc

 /*
 *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 *
 *  Use of this source code is governed by a BSD-style license
 *  that can be found in the LICENSE file in the root of the source
 *  tree. An additional intellectual property rights grant can be found
 *  in the file PATENTS.  All contributing project authors may
 *  be found in the AUTHORS file in the root of the source tree.
 */
 
 #include <stddef.h>
 #include <stdint.h>
 
+#include "webrtc/base/thread.h"
 #include "webrtc/p2p/base/pseudotcp.h"
 
 namespace webrtc {
 class FakeIPseudoTcpNotify : public cricket::IPseudoTcpNotify {
  public:
   void OnTcpOpen(cricket::PseudoTcp* tcp) {}
   void OnTcpReadable(cricket::PseudoTcp* tcp) {}
   void OnTcpWriteable(cricket::PseudoTcp* tcp) {}
   void OnTcpClosed(cricket::PseudoTcp* tcp, uint32_t error) {}
 
   cricket::IPseudoTcpNotify::WriteResult TcpWritePacket(cricket::PseudoTcp* tcp,
                                                         const char* buffer,
                                                         size_t len) {
     return cricket::IPseudoTcpNotify::WriteResult::WR_SUCCESS;
   }
 };
 
 struct Environment {
   cricket::PseudoTcp* ptcp;

[pbos-webrtc, 2016/09/27 19:43:49]

Move struct members down to after the constructor, and use init lists if
possible.

[phoglund, 2016/09/28 08:24:19]

Done.

   explicit Environment(cricket::IPseudoTcpNotify* notifier) {
     ptcp = new cricket::PseudoTcp(notifier, 0);
   }
+
+  rtc::AutoThread thread;
 };
 
 Environment* env = new Environment(new FakeIPseudoTcpNotify());
 
 void FuzzOneInput(const uint8_t* data, size_t size) {
   env->ptcp->NotifyPacket(reinterpret_cast<const char*>(data), size);

[pbos-webrtc, 2016/09/27 19:43:49]

Could the environment here including FakeIPseudo.. just be stack allocated?

[phoglund, 2016/09/28 08:24:19]

No, it core dumps. I didn't investigate further why it does that. It's
apparently fine to leak some memory in a fuzzer program, so I think we should
just leave it as is. Also, if there's any state in ptcp, we'll be accumulating
state over many calls to FuzzOneInput, and I think that's a good thing since we
can reach more code. With stack alloc ptcp gets constructed and destructed once
per call.

 }
 }  // namespace webrtc