Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2365363003: Delete winfirewall.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete winfirewall.h. BUG=webrtc:6424 Committed: https://crrev.com/91e1a1abeffaa039f866163addd2ea51ff84912c Cr-Commit-Position: refs/heads/master@{#14511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -256 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/base/winfirewall.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/base/winfirewall.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D webrtc/base/winfirewall_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
nisse-webrtc
4 years, 2 months ago (2016-09-27 07:27:33 UTC) #2
pthatcher1
lgtm
4 years, 2 months ago (2016-10-03 22:30:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2365363003/1
4 years, 2 months ago (2016-10-04 07:32:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 2 months ago (2016-10-04 09:32:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2365363003/1
4 years, 2 months ago (2016-10-05 06:18:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 06:26:26 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 06:26:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91e1a1abeffaa039f866163addd2ea51ff84912c
Cr-Commit-Position: refs/heads/master@{#14511}

Powered by Google App Engine
This is Rietveld 408576698