Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: webrtc/modules/audio_processing/level_controller/level_controller.cc

Issue 2364553003: Change of the format of the log output in the level controller (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/level_controller/level_controller.cc
diff --git a/webrtc/modules/audio_processing/level_controller/level_controller.cc b/webrtc/modules/audio_processing/level_controller/level_controller.cc
index c0edeb91c50f5a472019f07eb45ce97910d9ea12..247b7d0c615152d18003f32b5160f717e94e0305 100644
--- a/webrtc/modules/audio_processing/level_controller/level_controller.cc
+++ b/webrtc/modules/audio_processing/level_controller/level_controller.cc
@@ -156,23 +156,21 @@ void LevelController::Metrics::Update(float long_term_peak_level,
const int frame_peak_level_dbfs = static_cast<int>(
10 * log10(frame_peak_level * frame_peak_level + 1e-10f) - kdBFSOffset);
- LOG(LS_INFO) << "Level Controller metrics: " << std::endl
- << "Max noise power: " << max_noise_power_dbfs
- << " dBFS" << std::endl
- << "Average noise power: " << average_noise_power_dbfs
- << " dBFS" << std::endl
- << "Max long term peak level: " << max_peak_level_dbfs
- << " dBFS" << std::endl
+ LOG(LS_INFO) << "Level Controller metrics: {"
the sun 2016/09/23 12:31:33 Consider putting this in a ToString() method, like
peah-webrtc 2016/10/03 10:37:02 I agree, but in this case not all the reported met
+ << "Max noise power: " << max_noise_power_dbfs << " dBFS, "
+ << "Average noise power: " << average_noise_power_dbfs
+ << " dBFS, "
+ << "Max long term peak level: " << max_peak_level_dbfs
+ << " dBFS, "
<< "Average long term peak level: " << average_peak_level_dbfs
- << " dBFS" << std::endl
- << "Max gain: " << max_gain_db << " dB"
- << std::endl
- << "Average gain: " << average_gain_db << " dB"
- << std::endl
- << "Long term peak level: "
- << long_term_peak_level_dbfs << " dBFS" << std::endl
- << "Last frame peak level: " << frame_peak_level_dbfs
- << " dBFS";
+ << " dBFS, "
+ << "Max gain: " << max_gain_db << " dB, "
+ << "Average gain: " << average_gain_db << " dB, "
+ << "Long term peak level: " << long_term_peak_level_dbfs
+ << " dBFS, "
+ << "Last frame peak level: " << frame_peak_level_dbfs
+ << " dBFS"
+ << "}";
Reset();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698