Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2364553003: Change of the format of the log output in the level controller (Closed)

Created:
4 years, 3 months ago by peah-webrtc
Modified:
4 years, 2 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

The current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues. BUG=webrtc:6408 Committed: https://crrev.com/8a9b0f8e02c7539cf21c3de174dad0f8e2becc06 Cr-Commit-Position: refs/heads/master@{#14489}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M webrtc/modules/audio_processing/level_controller/level_controller.cc View 1 chunk +14 lines, -16 lines 2 comments Download

Messages

Total messages: 15 (7 generated)
peah-webrtc
4 years, 3 months ago (2016-09-22 07:52:58 UTC) #3
the sun
lgtm https://codereview.webrtc.org/2364553003/diff/1/webrtc/modules/audio_processing/level_controller/level_controller.cc File webrtc/modules/audio_processing/level_controller/level_controller.cc (right): https://codereview.webrtc.org/2364553003/diff/1/webrtc/modules/audio_processing/level_controller/level_controller.cc#newcode159 webrtc/modules/audio_processing/level_controller/level_controller.cc:159: LOG(LS_INFO) << "Level Controller metrics: {" Consider putting ...
4 years, 3 months ago (2016-09-23 12:31:33 UTC) #4
peah-webrtc
https://codereview.webrtc.org/2364553003/diff/1/webrtc/modules/audio_processing/level_controller/level_controller.cc File webrtc/modules/audio_processing/level_controller/level_controller.cc (right): https://codereview.webrtc.org/2364553003/diff/1/webrtc/modules/audio_processing/level_controller/level_controller.cc#newcode159 webrtc/modules/audio_processing/level_controller/level_controller.cc:159: LOG(LS_INFO) << "Level Controller metrics: {" On 2016/09/23 12:31:33, ...
4 years, 2 months ago (2016-10-03 10:37:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2364553003/1
4 years, 2 months ago (2016-10-03 10:37:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/15730)
4 years, 2 months ago (2016-10-03 10:56:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2364553003/1
4 years, 2 months ago (2016-10-04 06:15:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 07:06:07 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 07:06:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a9b0f8e02c7539cf21c3de174dad0f8e2becc06
Cr-Commit-Position: refs/heads/master@{#14489}

Powered by Google App Engine
This is Rietveld 408576698