|
|
Created:
4 years, 3 months ago by peah-webrtc Modified:
4 years, 2 months ago Reviewers:
the sun CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionThe current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues.
BUG=webrtc:6408
Committed: https://crrev.com/8a9b0f8e02c7539cf21c3de174dad0f8e2becc06
Cr-Commit-Position: refs/heads/master@{#14489}
Patch Set 1 #
Total comments: 2
Created: 4 years, 3 months ago
Messages
Total messages: 15 (7 generated)
Description was changed from ========== This CL changes the format of the log output in the level controller The current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues. BUG=webrtc:6408 ========== to ========== The current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues. BUG=webrtc:6408 ==========
peah@webrtc.org changed reviewers: + solenberg@webrtc.org
lgtm https://codereview.webrtc.org/2364553003/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/level_controller/level_controller.cc (right): https://codereview.webrtc.org/2364553003/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/level_controller/level_controller.cc:159: LOG(LS_INFO) << "Level Controller metrics: {" Consider putting this in a ToString() method, like you did for the Config struct (would use field names then, rather than plain text, btw).
The CQ bit was checked by peah@webrtc.org
https://codereview.webrtc.org/2364553003/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/level_controller/level_controller.cc (right): https://codereview.webrtc.org/2364553003/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/level_controller/level_controller.cc:159: LOG(LS_INFO) << "Level Controller metrics: {" On 2016/09/23 12:31:33, the sun wrote: > Consider putting this in a ToString() method, like you did for the Config struct > (would use field names then, rather than plain text, btw). I agree, but in this case not all the reported metrics are stored as fields as they are handled before being reported. I'll land this CL as it is, but I'd be happy to to change this later.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/15730)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== The current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues. BUG=webrtc:6408 ========== to ========== The current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues. BUG=webrtc:6408 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== The current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues. BUG=webrtc:6408 ========== to ========== The current format of the log output of the level controller differs from the rest of the log. Furthermore, it is hard to automatically parse. This CL changes the format to be a JSON-type format which does not have those issues. BUG=webrtc:6408 Committed: https://crrev.com/8a9b0f8e02c7539cf21c3de174dad0f8e2becc06 Cr-Commit-Position: refs/heads/master@{#14489} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8a9b0f8e02c7539cf21c3de174dad0f8e2becc06 Cr-Commit-Position: refs/heads/master@{#14489} |